Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download golangci-lint as a binary #4955

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@cblecker
Copy link
Member

commented Sep 6, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot requested review from jewzaam and mwoodson Sep 6, 2019

@cblecker cblecker force-pushed the cblecker:velero-goproxy branch 2 times, most recently from ac6aef7 to 5b2154c Sep 6, 2019

@cblecker cblecker force-pushed the cblecker:velero-goproxy branch from 5b2154c to cb6ecd2 Sep 6, 2019

@cblecker cblecker changed the title Use GOPROXY when installing linter Download golangci-lint as a binary Sep 6, 2019

@openshift-ci-robot openshift-ci-robot added size/S and removed size/XS labels Sep 6, 2019

@c-e-brumm

This comment has been minimized.

Copy link

commented Sep 6, 2019

/lgtm

@c-e-brumm

This comment has been minimized.

Copy link

commented Sep 6, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c-e-brumm, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e928654 into openshift:master Sep 6, 2019

16 checks passed

ci/prow/ci-operator-config Job succeeded.
Details
ci/prow/config Job succeeded.
Details
ci/prow/core-dry Job succeeded.
Details
ci/prow/core-valid Job succeeded.
Details
ci/prow/correctly-sharded-config Job succeeded.
Details
ci/prow/generated-config Job succeeded.
Details
ci/prow/generated-dashboards Job succeeded.
Details
ci/prow/ordered-prow-config Job succeeded.
Details
ci/prow/owners Job succeeded.
Details
ci/prow/pj-rehearse Job succeeded.
Details
ci/prow/prow-config-filenames Job succeeded.
Details
ci/prow/prow-config-semantics Job succeeded.
Details
ci/rehearse/openshift/managed-velero-operator/master/verify Job succeeded.
Details
ci/rehearse/openshift/managed-velero-operator/release-4.2/verify Job succeeded.
Details
ci/rehearse/openshift/managed-velero-operator/release-4.3/verify Job succeeded.
Details
tide In merge pool.
Details
@openshift-ci-robot

This comment has been minimized.

Copy link

commented Sep 6, 2019

@cblecker: Updated the following 6 configmaps:

  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-managed-velero-operator-release-4.3.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-release-4.3.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-managed-velero-operator-master.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-managed-velero-operator-master.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-master.yaml
  • ci-operator-4.2-configs configmap in namespace ci using the following files:
    • key openshift-managed-velero-operator-release-4.2.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-release-4.2.yaml
  • ci-operator-4.2-configs configmap in namespace ci-stg using the following files:
    • key openshift-managed-velero-operator-release-4.2.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-release-4.2.yaml
  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-managed-velero-operator-release-4.3.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-release-4.3.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the cblecker:velero-goproxy branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.