Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OCPQE-19493: Change facility to metro" #50097

Merged

Conversation

sgoveas
Copy link
Contributor

@sgoveas sgoveas commented Mar 21, 2024

Reverts #48680

Needs PR openshift-metal3/dev-scripts#1633 to be merged first. But a required test is failing and needs further investigation. Reverting to unblock tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 21, 2024

@sgoveas: This pull request references OCPQE-19493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #48680

Needs PR openshift-metal3/dev-scripts#1633 to be merged first. But a required test is failing and needs further investigation. Reverting to unblock tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sgoveas: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-master-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.17-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.16-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.15-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.13-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.12-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.11-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.10-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.9-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.8-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.7-e2e-metal-assisted openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted-ipv6 openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted-single-node openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted-cnv openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted-lvm openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted-odf openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted-external openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-e2e-ai-operator-ztp openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-ocm-2.10-e2e-ai-operator-ztp openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-ocm-2.8-e2e-ai-operator-ztp openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-ocm-2.7-e2e-ai-operator-ztp openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-release-ocm-2.9-e2e-ai-operator-ztp openshift/assisted-installer presubmit Registry content changed
pull-ci-openshift-assisted-installer-master-edge-publish-multi-arch-images-dry-run openshift/assisted-installer presubmit Registry content changed

A total of 679 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@sgoveas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aleskandro
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@danilo-gemoli
Copy link
Contributor

/lgtm

@sgoveas
Copy link
Contributor Author

sgoveas commented Mar 21, 2024

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 21, 2024
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, aleskandro, danilo-gemoli, sgoveas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2c087c6 into openshift:master Mar 21, 2024
18 checks passed
sgoveas added a commit to sgoveas/release that referenced this pull request Apr 2, 2024
sgoveas added a commit to sgoveas/release that referenced this pull request Apr 2, 2024
…" (openshift#50097)"

This reverts commit 2c087c6.

and adds ansible python interpreter
openshift-merge-bot bot pushed a commit that referenced this pull request Apr 3, 2024
…)" (#50490)

This reverts commit 2c087c6.

and adds ansible python interpreter
@sgoveas sgoveas deleted the revert-48680-update_fac_arm64 branch April 8, 2024 14:30
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants