Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang/golangci-lint versions for managed-velero-operator #6116

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Nov 26, 2019

@dak1n1
dak1n1 approved these changes Nov 27, 2019
Copy link

dak1n1 left a comment

/lgtm

Copy link

yithian left a comment

lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link
Contributor

openshift-ci-robot commented Nov 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dak1n1, yithian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link
Contributor

openshift-bot commented Nov 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2c4a9ba into openshift:master Nov 27, 2019
16 of 21 checks passed
16 of 21 checks passed
ci/rehearse/openshift/managed-velero-operator/master/test Job failed.
Details
ci/rehearse/openshift/managed-velero-operator/master/verify Job failed.
Details
ci/prow/pj-rehearse Job triggered.
Details
ci/rehearse/openshift/managed-velero-operator/master/images Job triggered.
Details
tide Not mergeable. Retesting: ci/prow/owners
Details
ci/build-farm/build01-dry Job succeeded.
Details
ci/prow/ci-operator-config Job succeeded.
Details
ci/prow/ci-operator-registry Job succeeded.
Details
ci/prow/config Job succeeded.
Details
ci/prow/core-dry Job succeeded.
Details
ci/prow/core-valid Job succeeded.
Details
ci/prow/correctly-sharded-config Job succeeded.
Details
ci/prow/generated-config Job succeeded.
Details
ci/prow/generated-dashboards Job succeeded.
Details
ci/prow/ordered-prow-config Job succeeded.
Details
ci/prow/owners Job succeeded.
Details
ci/prow/prow-config Job succeeded.
Details
ci/prow/prow-config-filenames Job succeeded.
Details
ci/prow/prow-config-semantics Job succeeded.
Details
ci/prow/services-dry Job succeeded.
Details
ci/prow/services-valid Job succeeded.
Details
@openshift-ci-robot

This comment has been minimized.

Copy link
Contributor

openshift-ci-robot commented Nov 27, 2019

@cblecker: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-managed-velero-operator-master.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-managed-velero-operator-master.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-managed-velero-operator-master.yaml using file ci-operator/config/openshift/managed-velero-operator/openshift-managed-velero-operator-master.yaml

In response to this:

in prep for openshift/managed-velero-operator#23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the cblecker:mvo-golang-1.13 branch Nov 27, 2019
@openshift-ci-robot

This comment has been minimized.

Copy link
Contributor

openshift-ci-robot commented Nov 27, 2019

@cblecker: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/managed-velero-operator/master/verify 50fe9c1 link /test pj-rehearse
ci/rehearse/openshift/managed-velero-operator/master/test 50fe9c1 link /test pj-rehearse
ci/prow/pj-rehearse 50fe9c1 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.