Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1788419: fix builder image for oauth-proxy #6596

Merged
merged 1 commit into from Jan 8, 2020

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Jan 8, 2020

There seem to have been a golang bug, I wonder whether we can solve the issue we're observing in CI simply by using the correct builder image

@openshift-ci-robot
Copy link
Collaborator

@stlaz: This pull request references Bugzilla bug 1788419, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1788419: fix builder image for oauth-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 8, 2020
@stlaz
Copy link
Member Author

stlaz commented Jan 8, 2020

/cc @tnozicka @vrutkovs

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2020
@stlaz
Copy link
Member Author

stlaz commented Jan 8, 2020

oauth-proxy PR for builder versions in dockerfiles: openshift/oauth-proxy#145

Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
for new rehearsal run after openshift/oauth-proxy#145 merges

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@stlaz
Copy link
Member Author

stlaz commented Jan 8, 2020

/test pj-rehearse

@stlaz
Copy link
Member Author

stlaz commented Jan 8, 2020

/test all

@vrutkovs
Copy link
Member

vrutkovs commented Jan 8, 2020

Rehearse won't run e2e test (there's a bug for that). Lets try it and revert if things get worse?

@stlaz
Copy link
Member Author

stlaz commented Jan 8, 2020

/hold cancel
I see, in that case I'll remove the hold tag and lets get this merged and see.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, stlaz, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2536892 into openshift:master Jan 8, 2020
@openshift-ci-robot
Copy link
Collaborator

@stlaz: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-oauth-proxy-master.yaml using file ci-operator/config/openshift/oauth-proxy/openshift-oauth-proxy-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-oauth-proxy-master.yaml using file ci-operator/config/openshift/oauth-proxy/openshift-oauth-proxy-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-oauth-proxy-master.yaml using file ci-operator/config/openshift/oauth-proxy/openshift-oauth-proxy-master.yaml

In response to this:

There seem to have been a golang bug, I wonder whether we can solve the issue we're observing in CI simply by using the correct builder image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@stlaz: All pull requests linked via external trackers have merged. Bugzilla bug 1788419 has been moved to the MODIFIED state.

In response to this:

Bug 1788419: fix builder image for oauth-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
6 participants