Skip to content

Conversation

@barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Dec 1, 2025

The current version (1.64.8) is insufficient on all platforms to find lint errors. A PR in the openshift installer (openshift/installer#10121) will update the golangci-lint yaml file to version v2.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 1, 2025
@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request explicitly references no jira issue.

In response to this:

The current version (1.64.8) is insufficient on all platforms to find lint errors. A PR in the openshift installer (openshift/installer#10121) will update the golangci-lint yaml file to version v2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@openshift-ci openshift-ci bot requested review from jhixson74 and sadasu December 1, 2025 16:03
@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/test golint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

@barbacbd: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build06-dry
/test build07-dry
/test build08-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test labels
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test rover-groups-config-validation
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test verified-config
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry
/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

In response to this:

/test golint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/test ci-operator-config

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/test pull-ci-openshift-installer-main-golint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

@barbacbd: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build06-dry
/test build07-dry
/test build08-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test labels
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test rover-groups-config-validation
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test verified-config
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry
/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

In response to this:

/test pull-ci-openshift-installer-main-golint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/test all

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/test ci/prow/golint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

@barbacbd: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build06-dry
/test build07-dry
/test build08-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test labels
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test rover-groups-config-validation
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test verified-config
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry
/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint

In response to this:

/test ci/prow/golint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/pj-rehearse pull-ci-openshift-installer-main-golint

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

The current version (1.64.8) is insufficient on all platforms to find lint errors.
A PR in the openshift installer (openshift/installer#10121) will update
the golangci-lint yaml file to version v2.
@barbacbd barbacbd force-pushed the update-installer-golint branch from 8d85047 to 05f9763 Compare December 1, 2025 19:25
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@barbacbd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-artifacts-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-aws-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-azure-ovn-marketplace-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-azure-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-4control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-5control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-appliance-diskimage openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-iso-no-registry openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-none-platform openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv6-minimaliso openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-sno-ipv4-pxe openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-byo-subnet-role-security-groups openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-custom-dns-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-default-config openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-overlay-mtu-ovn-1200 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-custom-iam-profile openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-edge-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-edge-zones-manifest-validation openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-heterogeneous openshift/installer presubmit Ci-operator config changed

A total of 117 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@barbacbd
Copy link
Contributor Author

barbacbd commented Dec 1, 2025

/pj-rehearse pull-ci-openshift-installer-main-golint

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2025

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/main/golint 05f9763 link unknown /pj-rehearse pull-ci-openshift-installer-main-golint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants