Skip to content

Add incident detection UI tests to all 4.19+ configs#75225

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
DavidRajnoha:rhobs-obo-add-incidents-ui-tests
May 29, 2026
Merged

Add incident detection UI tests to all 4.19+ configs#75225
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
DavidRajnoha:rhobs-obo-add-incidents-ui-tests

Conversation

@DavidRajnoha

@DavidRajnoha DavidRajnoha commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

The monitoring-plugin-tests-monitoring-incidents-ui-integration ref was only present in the amd64-ocp-4.19-gcp variant. Add it to the remaining supported release configs (4.20-azure, 4.21-azure, 4.21-gcp-interop) so incident detection coverage matches across all release versions.

Summary by CodeRabbit

  • Tests
    • Added monitoring incidents UI integration testing to the observability operator's continuous integration workflows across multiple cloud platforms and Kubernetes versions (Azure 4.20, 4.21, and GCP interop) to improve test coverage.

@DavidRajnoha

Copy link
Copy Markdown
Contributor Author

/cc @IshwarKanse

@lihongyan1

Copy link
Copy Markdown
Contributor

Please rehearse run related jobs

@DavidRajnoha

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@DavidRajnoha: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@IshwarKanse

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2026
@DavidRajnoha

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@DavidRajnoha: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 11, 2026
@lihongyan1

Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@lihongyan1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@simonpasquier

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout base SHA 844737cbc22bbfc39221c63cec628c5a654bf287: error checking out "844737cbc22bbfc39221c63cec628c5a654bf287": exit status 128 fatal: unable to read tree (844737cbc22bbfc39221c63cec628c5a654bf287)

…onfigs

The monitoring-plugin-tests-monitoring-incidents-ui-integration ref was
only present in the amd64-ocp-4.19-gcp variant. Add it to the remaining
supported release configs (4.20-azure, 4.21-azure, 4.21-gcp-interop) so
incident detection coverage matches across all release versions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DavidRajnoha DavidRajnoha force-pushed the rhobs-obo-add-incidents-ui-tests branch from fbb3a97 to afabac2 Compare April 20, 2026 14:23
@DavidRajnoha

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@DavidRajnoha: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: de20d748-fda8-4318-8f8e-4d37c3ec16bb

📥 Commits

Reviewing files that changed from the base of the PR and between 0a9c8c8 and afabac2.

📒 Files selected for processing (3)
  • ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.20-azure.yaml
  • ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.21-azure.yaml
  • ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.21-gcp-interop.yaml

Walkthrough

Three CI operator configuration files for the rhobs observability-operator were updated to add a new test reference (monitoring-plugin-tests-monitoring-incidents-ui-integration) to their respective test workflows for different OpenShift versions and cloud platforms.

Changes

Cohort / File(s) Summary
CI Test Configuration Updates
ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.20-azure.yaml, rhobs-observability-operator-main__amd64-ocp-4.21-azure.yaml, rhobs-observability-operator-main__amd64-ocp-4.21-gcp-interop.yaml
Added monitoring-plugin-tests-monitoring-incidents-ui-integration test reference to the tests list in cron workflow configurations across multiple OpenShift versions and deployment environments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Add incident detection UI tests to all 4.19+ configs' directly and clearly summarizes the main change: adding the monitoring-plugin-tests-monitoring-incidents-ui-integration test reference to multiple configuration files (4.20-azure, 4.21-azure, and 4.21-gcp-interop).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies CI operator configuration YAML files to reference an existing Cypress UI test step. No Ginkgo test definitions or test titles are added or modified.
Test Structure And Quality ✅ Passed This PR only modifies CI-operator configuration YAML files and does not include any Ginkgo test code files (*_test.go) for review.
Microshift Test Compatibility ✅ Passed PR only modifies CI operator configuration files to reference an existing test; no new Ginkgo e2e tests are added to the codebase.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI configuration files to add references to existing Cypress-based test; no new Ginkgo e2e tests introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator configuration files to add a test reference, not deployment manifests, operator code, or controllers.
Ote Binary Stdout Contract ✅ Passed Pull request only modifies YAML CI configuration files that add test references. No test code (Go files) is changed, so OTE Binary Stdout Contract violations cannot occur.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The custom check targets new Ginkgo e2e tests, but this PR only adds YAML configuration references to an existing Cypress UI test. No new Go/Ginkgo e2e tests are introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@DavidRajnoha: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-gcp-interop-coo-production N/A periodic Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@DavidRajnoha

Copy link
Copy Markdown
Contributor Author
GCP 4.21 production Azure 4.21 stage Azure 4.20 stage
New PR #75225 tests n/a (not in target) PASSED (25m55s) PASSED (25m55s)
rhobs-obo-test-harness FAIL (21/33) FAIL (21/33) FAIL (21/33)
Operator pod found 0 0 0
Cluster install PASS PASS PASS
Gather steps PASS PASS PASS
Post-phase upi-installer n/a INFRA_IMAGE_PULL INFRA_IMAGE_PULL

The failures are not caused by PR #75225. All three jobs show the same pre-existing rhobs/observability-operator main regression where
OLM installs the subscription but the operator pod never becomes available. The incident detection UI tests that this PR adds passed in
both Azure jobs. Two new patterns were recorded in the ledger: obo_operator_pod_missing and upi_installer_image_pull_post_phase.

@danielmellado

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@danielmellado: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidRajnoha

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@DavidRajnoha: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidRajnoha

Copy link
Copy Markdown
Contributor Author

Azure:

 INFO[2026-05-28T19:21:16Z] Step coo-stage-monitoring-plugin-tests-monitoring-incidents-ui-integration succeeded after 45m40s. 

Azure 4.21:

 INFO[2026-05-28T20:00:35Z] Step coo-stage-monitoring-plugin-tests-monitoring-incidents-ui-integration succeeded after 44m48s. 

GCP 4.21:
0/25 nodes available, couldn't find the cli image – unrelated infra issue.

@simonpasquier could you lgtm and approve this, as the incident detection test inclusion is working properly?

@simonpasquier

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2026
@simonpasquier

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 29, 2026
@openshift-ci

openshift-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidRajnoha, IshwarKanse, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2026
@openshift-ci

openshift-ci Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@DavidRajnoha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage afabac2 link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-gcp-interop-coo-production afabac2 link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-gcp-interop-coo-production
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage afabac2 link unknown /pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c9b8e31 into openshift:main May 29, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants