Skip to content

increase logging view plugin testing resources#79643

Open
jgbernalp wants to merge 1 commit into
openshift:mainfrom
jgbernalp:increase-memory-for-logging-plugin
Open

increase logging view plugin testing resources#79643
jgbernalp wants to merge 1 commit into
openshift:mainfrom
jgbernalp:increase-memory-for-logging-plugin

Conversation

@jgbernalp
Copy link
Copy Markdown
Contributor

@jgbernalp jgbernalp commented May 22, 2026

Summary by CodeRabbit

This PR increases the Kubernetes resource limits and requests for the OpenShift logging-view-plugin's CI testing infrastructure across multiple release branches.

What changed: The container resource configurations in four CI operator configuration files have been updated to allocate more memory for the logging-view-plugin builds:

  • Memory limit: increased from 6Gi to 8Gi
  • Memory request: increased from 4Gi to 8Gi
  • CPU request: remains unchanged at 100m

Affected versions: These changes apply to:

  • Main branch (unreleased)
  • OCP 4.12 release branch
  • OCP 4.15 release branch
  • OCP 4.22 release branch

Impact: This increases the memory available during test execution for the logging-view-plugin across all current release versions, likely to address testing resource constraints or improve build reliability when running CI jobs for this component.

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c8168893-430d-4dd3-8f09-ed29862d2230

📥 Commits

Reviewing files that changed from the base of the PR and between 24ac8b7 and 8c7e1ea.

📒 Files selected for processing (4)
  • ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-main.yaml
  • ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-release-coo-ocp-4.12.yaml
  • ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-release-coo-ocp-4.15.yaml
  • ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-release-coo-ocp-4.22.yaml

Walkthrough

Four OpenShift CI operator configuration files for the logging-view-plugin are updated uniformly. Memory limits increase from 6Gi to 8Gi and memory requests from 4Gi to 8Gi. CPU request remains 100m across all files (main, OCP 4.12, OCP 4.15, and OCP 4.22).

Changes

Logging View Plugin Resource Configuration

Layer / File(s) Summary
Memory limit and request updates across all configs
ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-main.yaml, ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-release-coo-ocp-4.12.yaml, ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-release-coo-ocp-4.15.yaml, ci-operator/config/openshift/logging-view-plugin/openshift-logging-view-plugin-release-coo-ocp-4.22.yaml
Wildcard container resource limits and requests are updated uniformly across all four CI operator configuration files: memory limit increased to 8Gi, memory request increased to 8Gi, CPU request unchanged at 100m.

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: increasing memory and resource limits for the logging view plugin testing configuration across multiple OpenShift release config files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI config files, changing resource limits. No Ginkgo test code or test names are modified, so the check for stable test names is not applicable.
Test Structure And Quality ✅ Passed PR contains only YAML CI configuration changes for resource allocation, not Ginkgo test code. The custom check is not applicable to infrastructure/configuration-only changes.
Microshift Test Compatibility ✅ Passed This PR contains only YAML configuration changes for resource limits/requests in CI operator configs, with no new Ginkgo e2e tests added. The MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies YAML CI operator configuration files with no new Ginkgo e2e tests added; SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only modifies CI operator resource limits/requests (memory: 6Gi→8Gi, request: 4Gi→8Gi) with no scheduling constraints, affinity rules, or topology assumptions introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI operator configuration files, not source code. OTE Binary Stdout Contract check applies to Go binaries/code, not configuration files; no applicable violations exist.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only updates OpenShift CI operator resource configuration YAML files and does not add any new Ginkgo e2e tests. The custom check does not apply to non-test code changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2026
@openshift-ci openshift-ci Bot requested review from PeterYurkovich and zhuje May 22, 2026 08:45
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jgbernalp: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.22-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.22-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.22-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.22-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-fips-image-scan openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.15-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.15-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.15-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.15-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.12-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.12-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.12-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-coo-ocp-4.12-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jgbernalp
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jgbernalp: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2026

@jgbernalp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/logging-view-plugin/main/test-e2e 8c7e1ea link unknown /pj-rehearse pull-ci-openshift-logging-view-plugin-main-test-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@jgbernalp: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant