[DNM] increase compute nodes for serverless lp-interop jobs#79864
[DNM] increase compute nodes for serverless lp-interop jobs#79864maschmid wants to merge 5 commits into
Conversation
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds ChangesAWS Test Job Environment and Command Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maschmid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
so that SO `use_spot_instances` does not need to replace the machinesets
|
/pj-rehearse |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-knative-serverless-operator-release-1.37-ocp-4.22-lp-interop-cr-operator-e2e-aws |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__ocp-4.22-lp-interop.yaml (1)
174-174: Note: Single-zone deployment reduces redundancy.Setting
ZONES_COUNT: "1"means all 6 compute nodes will be provisioned in a single availability zone, eliminating multi-AZ redundancy. This is reasonable for a stability investigation (reduces network variability), but be aware that this configuration differs from typical production multi-zone deployments.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__ocp-4.22-lp-interop.yaml` at line 174, The manifest currently sets ZONES_COUNT: "1", which forces all compute nodes into a single availability zone and removes multi-AZ redundancy; if this was accidental, change ZONES_COUNT to "3" (or the cluster's expected AZ count) to restore multi-zone redundancy, otherwise explicitly document the intent by adding a comment/annotation near the ZONES_COUNT setting indicating this is a deliberate single-zone configuration for stability testing so reviewers know it is intentional.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__ocp-4.22-lp-interop.yaml`:
- Line 174: The manifest currently sets ZONES_COUNT: "1", which forces all
compute nodes into a single availability zone and removes multi-AZ redundancy;
if this was accidental, change ZONES_COUNT to "3" (or the cluster's expected AZ
count) to restore multi-zone redundancy, otherwise explicitly document the
intent by adding a comment/annotation near the ZONES_COUNT setting indicating
this is a deliberate single-zone configuration for stability testing so
reviewers know it is intentional.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 63536e7c-3097-42a0-8b97-bcadd5934aab
📒 Files selected for processing (1)
ci-operator/config/openshift-knative/serverless-operator/openshift-knative-serverless-operator-release-1.37__ocp-4.22-lp-interop.yaml
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@maschmid: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@maschmid: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
test only,
see if increasing the node count helps with the serverless lp-interop job stability
Summary by CodeRabbit
This PR updates OpenShift CI job configuration for the OpenShift Knative serverless-operator lp-interop jobs (release 1.37 on OCP 4.22) to investigate stability by changing how AWS test jobs are provisioned.
What changed, in practical terms:
Why:
Status and notes: