Skip to content

Add agent-ops mod-arch module to ODH dashboard CI builds#80040

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
Gkrumbach07:add-agent-ops-ci-build
Jun 5, 2026
Merged

Add agent-ops mod-arch module to ODH dashboard CI builds#80040
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
Gkrumbach07:add-agent-ops-ci-build

Conversation

@Gkrumbach07

@Gkrumbach07 Gkrumbach07 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Add OpenShift CI build configuration for the agent-ops modular architecture module in the ODH dashboard. This enables automated image builds on PRs and main branch merges, pushing to quay.io/opendatahub/odh-mod-arch-agent-ops.

Follows the same pattern as existing modules (maas, mlflow, gen-ai, etc.).

Changes

  • Added agent-ops image build entry using packages/agent-ops/Dockerfile.workspace
  • Added PR image mirror test (odh-mod-arch-agent-ops-pr-image-mirror)
  • Added postsubmit image mirror test (odh-mod-arch-agent-ops-image-mirror)

References

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR extends the OpenShift CI configuration for the opendatahub/odh-dashboard repository to automate image builds for the new agent-ops modular-architecture module.

What's being added:

  • A new image build pipeline that compiles the agent-ops module from packages/agent-ops/Dockerfile.workspace and publishes to quay.io/opendatahub/odh-mod-arch-agent-ops
  • Automated image builds triggered on every PR (with image mirror test validation)
  • Automated image builds and pushes to the registry on main branch commits (postsubmit job)

The configuration follows the established pattern already in place for other modular-architecture modules like maas, mlflow, and gen-ai. The change integrates agent-ops into the existing ODH dashboard CI/CD pipeline, enabling continuous delivery of the container image to the quay.io registry.

Lines changed: +19

Add OpenShift CI build configuration for the agent-ops modular
architecture module in the ODH dashboard. This enables automated
image builds on PRs and main branch merges, pushing to
quay.io/opendatahub/odh-mod-arch-agent-ops.

RHOAIENG-62592
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d9da65ea-4aed-433e-804c-ab5a637d358d

📥 Commits

Reviewing files that changed from the base of the PR and between 3fc25c7 and d2e31f2.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml

Walkthrough

This PR extends the ODH Dashboard CI operator configuration to add a new agent-ops container image build from a workspace Dockerfile and corresponding PR and postsubmit mirror jobs for distributing that image.

Changes

Agent-ops CI Configuration

Layer / File(s) Summary
Agent-ops image build and test configuration
ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
Image build definition maps ./packages/agent-ops/Dockerfile.workspace to odh-mod-arch-agent-ops-image. Two image-mirror test entries (PR and postsubmit) mirror this image, with the postsubmit job setting RELEASE_VERSION: main.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

rehearsals-ack, jira/valid-reference

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding CI build configuration for the agent-ops module to the ODH dashboard, which is the primary focus of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds CI operator configuration (YAML), not Ginkgo tests. Check for Ginkgo test name stability is not applicable to CI/CD configuration files.
Test Structure And Quality ✅ Passed PR adds agent-ops to OpenShift CI configuration (YAML), not Ginkgo test code; check is not applicable to pure CI configuration changes.
Microshift Test Compatibility ✅ Passed PR adds CI build configuration for agent-ops module with image builds and mirror tests, not Ginkgo e2e tests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds CI configuration for building and publishing the agent-ops image but does not add any Ginkgo e2e tests, making the SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI operator configuration files (image build and test definitions), not deployment manifests, operator code, or controllers. No topology-aware scheduling checks apply.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML files, not test code or executables with main() functions. OTE stdout contract checks are not applicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add Ginkgo e2e tests; only CI config YAML is modified to add build and image mirror test definitions for agent-ops module.
No-Weak-Crypto ✅ Passed PR adds only YAML CI/CD configuration for agent-ops module. No source code with weak cryptography patterns (MD5, SHA1, DES, RC4, Blowfish, ECB) or custom crypto implementations detected.
Container-Privileges ✅ Passed The PR adds CI build configuration for agent-ops without any privileged container settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root access).
No-Sensitive-Data-In-Logs ✅ Passed PR contains only CI/CD configuration for agent-ops image builds with non-sensitive environment variables (IMAGE_REPO, RELEASE_VERSION); no logging statements or sensitive data found.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from christianvogt and lucferbux June 3, 2026 14:11
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Hi @Gkrumbach07. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

cc @lucferbux @christianvogt — could one of you /ok-to-test and review? This adds the agent-ops CI build config following the same pattern as the other mod-arch modules (maas, mlflow, etc.).

@nananosirova

Copy link
Copy Markdown

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2026
@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/pj-rehearse generate

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/generate

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: job(s): generate either don't exist or were not found to be affected, and cannot be rehearsed

Auto-generated via `make jobs` from the config change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@openshift-ci[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Gkrumbach07: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-agent-ops-pr-image-mirror opendatahub-io/odh-dashboard presubmit Presubmit changed
pull-ci-opendatahub-io-odh-dashboard-main-images opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-automl-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-autorag-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-eval-hub-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-gen-ai-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-maas-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-mlflow-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-model-registry-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@openshift-merge-bot[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@lucferbux

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@lucferbux

Copy link
Copy Markdown
Contributor

/lgtm

@lucferbux

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026
@lucferbux

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@lucferbux

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@lucferbux: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/retest

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 5, 2026
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@Gkrumbach07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit ca2a59a into openshift:main Jun 5, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants