Update slack template for COO 4.19 periodics

[simonpasquier]

Summary by CodeRabbit

This PR updates the Slack notification templates used by the Cluster Observability Operator (COO) CI jobs for OpenShift 4.19.

What's changing:

The Slack message templates for two COO test definitions (coo-stage and coo-compat) have been redesigned to provide clearer, more structured information in CI notifications. Instead of single-line inline templates, the new templates use multi-line YAML block scalars that include:

• Explicit sections for COO image source and OCP version context
• Environment information (GCP for the amd64 test, AWS for the upstream test)
• Improved formatting of job status and logging details

These template changes make the periodic CI notifications more readable and informative while preserving the conditional success/failure styling and "View logs" link functionality.

Additionally, a minor refactoring was made to the Konflux CatalogSource helper script (rhobs-konflux-catalogsource-commands.sh), where the command sequencing after update_global_auth was normalized and a sleep was added for stability purposes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 66e1b5b7-ef28-4401-a5b3-08fb92754d74

📥 Commits

Reviewing files that changed from the base of the PR and between fb8c79b and 9bd26d3.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/rhobs/observability-operator/rhobs-observability-operator-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (3)

• ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.19-gcp.yaml
• ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__upstream-ocp-4.19-aws.yaml
• ci-operator/step-registry/rhobs/konflux-catalogsource/rhobs-konflux-catalogsource-commands.sh

---

Walkthrough

CI operator configurations for observability-operator tests and the konflux-catalogsource command script receive formatting and template updates. Report templates expand from inline single-line strings to multi-line YAML block scalars with additional static context fields. The bash script undergoes whitespace and comment normalization with no functional logic changes.

Changes

CI Operator Configuration Updates

Layer / File(s)	Summary
Report template multi-line formatting and context fields ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.19-gcp.yaml, ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__upstream-ocp-4.19-aws.yaml	Both coo-stage and coo-compat reporter templates replace inline compact strings with multi-line block scalars, adding preformatted context sections for FBC/COO image source, OCP version, and environment (GCP/AWS) before the conditional Slack status line and log link.
Konflux catalogsource script formatting and spacing ci-operator/step-registry/rhobs/konflux-catalogsource/rhobs-konflux-catalogsource-commands.sh	Whitespace normalization and comment spacing in main() function; command sequence (sleep, ICSP creation, marketplace check, catalog source creation, hypershift ICSP export) and error handling remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

ok-to-test

Suggested reviewers

• stevekuznetsov

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
No-Sensitive-Data-In-Logs	❌ Error	The shell script logs $COO_INDEX_IMAGE which exposes internal hostname registry-proxy.engineering.redhat.com in echo statements at lines 17 and 140.	Remove or redact the echo statements logging COO_INDEX_IMAGE, or only log the image name without the internal registry hostname.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating Slack templates for COO (observability-operator) 4.19 periodic tests, which is reflected in the modifications to two YAML configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies YAML CI config and bash scripts—not Go test files. No Ginkgo test patterns (It(), Describe(), Context(), When()) found. Check is not applicable.
Test Structure And Quality	✅ Passed	PR contains no Ginkgo test code modifications—only YAML CI configs and shell script changes, so the test structure check is not applicable.
Microshift Test Compatibility	✅ Passed	This PR modifies only CI configuration YAML files and a bash script; no new Ginkgo e2e tests are added, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies CI configuration YAML and step registry shell scripts only. No new Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	Modified files are CI infrastructure (Slack templates and test setup script), not deployment manifests or operator code. No scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies CI configuration YAMLs and a bash step script, not OTE test binaries. OTE Binary Stdout Contract check applies only to Go test binaries.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only CI infrastructure files (YAML configs and bash script), not Ginkgo e2e tests. Check applies only when new e2e tests are added.
No-Weak-Crypto	✅ Passed	PR contains only Slack template updates and bash formatting changes. No weak cryptography, custom crypto, or unsafe secret comparisons detected.
Container-Privileges	✅ Passed	No container privilege escalation settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) found in the modified CI configuration YAML files or bash script.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage	N/A	periodic	Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.12-azure-coo-stage	N/A	periodic	Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.14-azure-coo-stage	N/A	periodic	Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.17-gcp-coo-stage-dast	N/A	periodic	Registry content changed
periodic-ci-rhobs-observability-operator-main-arm64-ocp-4.16-gcp-coo-stage	N/A	periodic	Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.21-azure-coo-stage	N/A	periodic	Registry content changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-upstream-ocp-4.19-aws-coo-compat	N/A	periodic	Ci-operator config changed
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.18-gcp-coo-stage	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[simonpasquier]

/pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage
/pj-rehearse periodic-ci-rhobs-observability-operator-main-upstream-ocp-4.19-aws-coo-compat

[openshift-merge-bot]

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[simonpasquier]

/cc @jan--f

[openshift-merge-bot]

@simonpasquier: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[openshift-merge-bot]

@openshift-ci[bot]: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[simonpasquier]

/pj-rehearse periodic-ci-rhobs-observability-operator-main-upstream-ocp-4.19-aws-coo-compat

[simonpasquier]

/pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage

[openshift-merge-bot]

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage	9bd26d3	link	unknown	/pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.19-gcp-coo-stage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[simonpasquier]

/pj-rehearse ack

[openshift-merge-bot]

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jan--f]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/rhobs/observability-operator/OWNERS [jan--f,simonpasquier]
• ci-operator/jobs/rhobs/observability-operator/OWNERS [jan--f,simonpasquier]
• ci-operator/step-registry/rhobs/konflux-catalogsource/OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment