Skip to content

onboard the opendatahub workbenches onto prow/tide#80117

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
harshad16:onboard-odh-workbenches
Jun 4, 2026
Merged

onboard the opendatahub workbenches onto prow/tide#80117
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
harshad16:onboard-odh-workbenches

Conversation

@harshad16

@harshad16 harshad16 commented Jun 4, 2026

Copy link
Copy Markdown
Member

onboard the opendatahub workbenches onto prow/tide
Related-to: https://redhat.atlassian.net/browse/RHOAIENG-66496

Summary by CodeRabbit

This PR onboards the OpenDataHub opendatahub-io/workbenches repository onto Prow/Tide by adding repository-specific Prow plugin and Tide configurations to the release repository.

What the change does in practical terms

  • Enables Prow automation and external plugin integrations for the opendatahub-io/workbenches repo so GitHub events are handled by the cluster's Prow services.
  • Configures Tide auto-merge behavior so PRs in opendatahub-io/workbenches are considered for automatic merging only when required labels are present and no blocking labels apply.

Key configuration details

  • core-services/prow/02_config/opendatahub-io/workbenches/_pluginconfig.yaml

    • Approve plugin configured for opendatahub-io/workbenches with require_self_approval: false (self-approval disabled).
    • External plugins wired for the repo (with service endpoints and the GitHub events that trigger them): refresh, cherrypick, needs-rebase, backport-verifier, payload-testing-prow-plugin, jira-lifecycle-plugin, pipeline-controller, multi-pr-prow-plugin, ship-hook.
    • lgtm configured with review_acts_as_lgtm: true (reviews count as LGTM).
    • Enables a curated set of standard Prow plugins for the repo (assign, blunderbuss, label, lgtm, lifecycle, hold, trigger, verify-owners, owners-label, approve, etc.).
    • Adds a triggers entry granting openshift-merge-bot as a trusted_app for org_invite handling.
  • core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml

    • Adds a Tide query scoped to opendatahub-io/workbenches that requires both the approved and lgtm labels.
    • Declares missing/blocking labels that prevent Tide merging: backports/unvalidated-commits, do-not-merge/hold, do-not-merge/invalid-owners-file, do-not-merge/work-in-progress, jira/invalid-bug, needs-rebase.

Impact

  • The opendatahub-io/workbenches repository is now integrated with the cluster Prow plugins and Tide auto-merge rules, enabling automated label-driven merging, external plugin handling, and standard Prow workflows for PR lifecycle management.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 45a80919-1043-44fe-8b12-b7fadc6e0228

📥 Commits

Reviewing files that changed from the base of the PR and between 8c2cc19 and 6e78062.

📒 Files selected for processing (2)
  • core-services/prow/02_config/opendatahub-io/workbenches/_pluginconfig.yaml
  • core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml
  • core-services/prow/02_config/opendatahub-io/workbenches/_pluginconfig.yaml

Walkthrough

Adds repository-level Prow plugin settings and tide merge rules for opendatahub-io/workbenches: disables self-approval, registers multiple external plugins and their event triggers, enables LGTM and a curated plugin allowlist, grants openshift-merge-bot org_invite trust, and configures tide queries requiring approved + lgtm.

Changes

Prow Configuration for opendatahub-io/workbenches

Layer / File(s) Summary
Approval rules and external plugin handlers
core-services/prow/02_config/opendatahub-io/workbenches/_pluginconfig.yaml
approve.require_self_approval: false is set; multiple external_plugins are wired to HTTP endpoints with specific GitHub event triggers; triggers.org_invite adds trusted_apps: openshift-merge-bot.
LGTM, plugin allowlist and tide rules
core-services/prow/02_config/opendatahub-io/workbenches/_pluginconfig.yaml, core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml
lgtm configured as LGTM, a curated plugins allowlist added, and tide.queries requires both approved and lgtm labels while listing missingLabels (backports/unvalidated-commits, do-not-merge/hold, do-not-merge/invalid-owners-file, do-not-merge/work-in-progress, jira/invalid-bug, needs-rebase) scoped to the repo.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

lgtm

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: onboarding OpenDataHub workbenches onto prow/tide infrastructure, matching both file changes in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The check for stable Ginkgo test names is not applicable—the PR contains only YAML configuration files for Prow/Tide, with no Go test code or Ginkgo test declarations.
Test Structure And Quality ✅ Passed PR contains only YAML configuration files for Prow/Tide; no Ginkgo test code present. Custom check for test structure is not applicable.
Microshift Test Compatibility ✅ Passed PR adds only Prow CI configuration files (YAML), not Ginkgo e2e tests. The MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only Prow CI configuration files (YAML), not Ginkgo e2e tests. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds Prow CI/CD pipeline configuration files only; no deployment manifests, operator code, controllers, or scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML configuration files for Prow/Tide. No OTE binary code, test binaries, or executable code present that could violate stdout contracts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only YAML Prow configuration files for opendatahub-io/workbenches; no Ginkgo e2e tests are added, so the IPv6 compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PR contains only YAML configuration files for Prow/Tide CI system with no weak cryptography, custom crypto, or insecure secret comparisons detected.
Container-Privileges ✅ Passed PR contains only Prow CI/CD configuration files with no container/K8s manifest specs. No privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds two YAML configuration files (pluginconfig and prowconfig) for Prow CI/CD. Both files contain no logging statements, credentials, passwords, tokens, API keys, PII, or other sensitive data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from deepsm007 and droslean June 4, 2026 17:29
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 4, 2026
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16 harshad16 force-pushed the onboard-odh-workbenches branch from 8c2cc19 to 6e78062 Compare June 4, 2026 18:49
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@harshad16: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jstourac jstourac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@harshad16: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 80d0de0 into openshift:main Jun 4, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@harshad16: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-opendatahub-io-workbenches-_prowconfig.yaml using file core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-opendatahub-io-workbenches-_prowconfig.yaml using file core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml
Details

In response to this:

onboard the opendatahub workbenches onto prow/tide
Related-to: https://redhat.atlassian.net/browse/RHOAIENG-66496

Summary by CodeRabbit

This PR onboards the OpenDataHub opendatahub-io/workbenches repository onto Prow/Tide by adding repository-specific Prow plugin and Tide configurations to the release repository.

What the change does in practical terms

  • Enables Prow automation and external plugin integrations for the opendatahub-io/workbenches repo so GitHub events are handled by the cluster's Prow services.
  • Configures Tide auto-merge behavior so PRs in opendatahub-io/workbenches are considered for automatic merging only when required labels are present and no blocking labels apply.

Key configuration details

  • core-services/prow/02_config/opendatahub-io/workbenches/_pluginconfig.yaml

  • Approve plugin configured for opendatahub-io/workbenches with require_self_approval: false (self-approval disabled).

  • External plugins wired for the repo (with service endpoints and the GitHub events that trigger them): refresh, cherrypick, needs-rebase, backport-verifier, payload-testing-prow-plugin, jira-lifecycle-plugin, pipeline-controller, multi-pr-prow-plugin, ship-hook.

  • lgtm configured with review_acts_as_lgtm: true (reviews count as LGTM).

  • Enables a curated set of standard Prow plugins for the repo (assign, blunderbuss, label, lgtm, lifecycle, hold, trigger, verify-owners, owners-label, approve, etc.).

  • Adds a triggers entry granting openshift-merge-bot as a trusted_app for org_invite handling.

  • core-services/prow/02_config/opendatahub-io/workbenches/_prowconfig.yaml

  • Adds a Tide query scoped to opendatahub-io/workbenches that requires both the approved and lgtm labels.

  • Declares missing/blocking labels that prevent Tide merging: backports/unvalidated-commits, do-not-merge/hold, do-not-merge/invalid-owners-file, do-not-merge/work-in-progress, jira/invalid-bug, needs-rebase.

Impact

  • The opendatahub-io/workbenches repository is now integrated with the cluster Prow plugins and Tide auto-merge rules, enabling automated label-driven merging, external plugin handling, and standard Prow workflows for PR lifecycle management.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants