Skip to content

Revert "Add agent-ops CI build and image mirror for odh-dashboard"#80211

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Gkrumbach07:revert-agent-ops-mirror
Jun 8, 2026
Merged

Revert "Add agent-ops CI build and image mirror for odh-dashboard"#80211
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
Gkrumbach07:revert-agent-ops-mirror

Conversation

@Gkrumbach07

@Gkrumbach07 Gkrumbach07 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This reverts commit ca2a59a (PR #80040).

The Prow image mirror job fails with unauthorized when pushing to quay.io/opendatahub/odh-mod-arch-agent-ops because the CI robot account doesn't have push access. This blocks CI for all PRs merging to opendatahub-io/odh-dashboard.

The quay repo exists and Konflux (which handles the actual builds) has access and is working. The Prow mirror will be re-added once the CI robot is granted push access (tracked in RHOAIENG-63302).

/cc @lferrnan

Summary by CodeRabbit

This PR reverts the agent-ops module addition to the ODH dashboard's CI pipeline. The revert addresses a blocking issue where the Prow image mirror job fails with authorization errors when attempting to push the built agent-ops image to quay.io/opendatahub/odh-mod-arch-agent-ops.

What's changing:

The CI configuration for opendatahub-io/odh-dashboard (main branch) has been rolled back to remove:

  • The odh-mod-arch-agent-ops-image build configuration from the images section
  • Both the PR (odh-mod-arch-agent-ops-pr-image-mirror) and postsubmit (odh-mod-arch-agent-ops-image-mirror) image mirror test jobs

Why:

The CI robot account used by Prow lacks push permissions to the target quay.io repository, causing all image mirror jobs to fail and blocking PR merges to the odh-dashboard repository. While Konflux (which performs the upstream builds) has working access, the Prow mirror job cannot complete. This access issue is tracked separately (RHOAIENG-63302), and the agent-ops image mirror will be re-added once the CI robot receives the necessary push permissions.

Impact:

The odh-dashboard CI pipeline will no longer attempt to build and mirror the agent-ops image until proper access credentials are established.

This reverts commit ca2a59a.

The Prow image mirror job fails with "unauthorized" when pushing to
quay.io/opendatahub/odh-mod-arch-agent-ops because the CI robot
account doesn't have push access. This blocks CI for all PRs merging
to opendatahub-io/odh-dashboard.

The quay repo exists and Konflux (which handles the actual builds)
has access. The Prow mirror will be re-added once the CI robot
is granted push access.

Ref: RHOAIENG-63302
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0c942894-71b3-4f16-b7b4-803c515d7421

📥 Commits

Reviewing files that changed from the base of the PR and between 0362971 and fefd2e8.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml

Walkthrough

The PR removes the agent-ops image build and test mirror configuration from the CI operator configuration file for the odh-dashboard project, eliminating its image entry and associated test jobs.

Changes

Remove agent-ops CI configuration

Layer / File(s) Summary
Remove agent-ops image and test mirror configuration
ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
The images.items section no longer includes the agent-ops Dockerfile entry. The tests section no longer contains the odh-mod-arch-agent-ops-* mirror job definitions for both PR and postsubmit variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • openshift/release#80040: This PR reverses the CI configuration introduced in that PR by removing the agent-ops image entry and the odh-mod-arch-agent-ops-* mirror jobs.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • lucferbux
  • christianvogt
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting a previous commit that added agent-ops CI build and image mirror functionality, which is exactly what the changeset does.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies CI configuration YAML files only, not Ginkgo test code. The check for Ginkgo test names is not applicable to this repository, which contains no test code.
Test Structure And Quality ✅ Passed PR contains only CI configuration (YAML) changes to ci-operator, not Ginkgo test code. The custom check for "Test Structure and Quality" is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only reverts CI operator config changes; custom check only applies when new e2e tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are exclusively to CI operator YAML configuration files, which fall outside the scope of this SNO test compatibility check.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies only a CI operator configuration file (opendatahub-io-odh-dashboard-main.yaml), not deployment manifests, operator code, or controllers. The custom check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI configuration changes with no executable code; OTE Binary Stdout Contract check is inapplicable to infrastructure/configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI configuration YAML (reverting agent-ops image mirror setup); no Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PR modifies only a YAML CI configuration file; no weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or insecure secret comparisons found.
Container-Privileges ✅ Passed PR modifies CI operator config only; no container/K8s manifests with privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation found.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data (passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data) found in the modified YAML configuration or commit message.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hi @Gkrumbach07. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Gkrumbach07: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-odh-dashboard-main-images opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-automl-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-autorag-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-eval-hub-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-gen-ai-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-maas-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-mlflow-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-model-registry-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: needs-ok-to-test label found, no rehearsals will be run

@andrewballantyne

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2026

@andrewballantyne andrewballantyne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causing some blocking pipeline issues due to setup externally to this repo -- we'll swing back with this after those are resolved.

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2026

@manaswinidas manaswinidas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@manaswinidas: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, Gkrumbach07, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@Gkrumbach07: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Gkrumbach07

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Gkrumbach07: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 8, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit a2a3be4 into openshift:main Jun 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants