Skip to content

Override OPCT_CLI_IMAGE to latest for nightly 5.0 AWS periodic jobs#80220

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:06081359-bot-changes
Open

Override OPCT_CLI_IMAGE to latest for nightly 5.0 AWS periodic jobs#80220
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:06081359-bot-changes

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Override OPCT_CLI_IMAGE to quay.io/opct/opct:latest at the job level for the existing OPCT periodic jobs in the nightly-5.0 config. This picks up the latest OPCT bug fixes and visibility improvements from master without waiting for a formal release.

Changes

Added OPCT_CLI_IMAGE: quay.io/opct/opct:latest to the env of both OPCT periodic jobs in openshift-release-main__nightly-5.0.yaml:

  • opct-platform-external-aws-ccm — External platform conformance with CCM
  • opct-platform-external-aws — External platform conformance

This overrides the workflow-level default (v0.6.5) set in opct-conformance-external-aws-workflow.yaml.

Diff

# opct-platform-external-aws-ccm
     env:
+      OPCT_CLI_IMAGE: quay.io/opct/opct:latest
       PLATFORM_EXTERNAL_CCM_ENABLED: "yes"

# opct-platform-external-aws
+    env:
+      OPCT_CLI_IMAGE: quay.io/opct/opct:latest
     workflow: opct-conformance-external-aws

Summary by CodeRabbit

This PR updates the nightly-5.0 CI configuration for OpenShift's OPCT (OpenShift Platform Conformance Test) periodic jobs so two nightly-5.0 OPCT periodic jobs use the OPCT image from master instead of the workflow-level pinned release.

  • File changed: ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • Change: added environment variable override OPCT_CLI_IMAGE: quay.io/opct/opct:latest to the steps.env of these jobs:
    • opct-platform-external-aws-ccm (External platform conformance with CCM) — env entry added alongside PLATFORM_EXTERNAL_CCM_ENABLED: "yes"
    • opct-platform-external-aws (External platform conformance) — env entry added; workflow remains opct-conformance-external-aws

Practical effect: these two nightly-5.0 periodic jobs will pick up the latest OPCT fixes and visibility improvements from master (quay.io/opct/opct:latest) rather than the workflow default v0.6.5 defined in opct-conformance-external-aws-workflow.yaml, enabling testing against the most recent OPCT development builds.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2c869d8b-1c59-44f3-8df0-762df7d1998a

📥 Commits

Reviewing files that changed from the base of the PR and between 978b5e2 and c0cc9d5.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

Walkthrough

This PR sets OPCT_CLI_IMAGE: quay.io/opct/opct:latest in the steps.env sections of opct-platform-external-aws-ccm and opct-platform-external-aws jobs in the nightly CI config.

Changes

OPCT Platform Test Environment Configuration

Layer / File(s) Summary
OPCT CLI image environment variables
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
The opct-platform-external-aws-ccm and opct-platform-external-aws test jobs are updated to define OPCT_CLI_IMAGE environment variable set to quay.io/opct/opct:latest in their respective env sections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/release#80178: Both PRs modify OPCT job configuration to set the OPCT_CLI_IMAGE environment variable across different workflow contexts.

Suggested labels

lgtm, rehearsals-ack

Suggested reviewers

  • mtulio
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately describes the main change: adding OPCT_CLI_IMAGE override to AWS periodic jobs in the nightly 5.0 configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI operator YAML config file adding env variables, not Ginkgo test code. Check targets test files and is inapplicable here.
Test Structure And Quality ✅ Passed This PR only modifies CI configuration YAML files, adding environment variables to OPCT jobs. No Ginkgo test code or Go test files are present, making the test quality check non-applicable.
Microshift Test Compatibility ✅ Passed PR modifies only CI configuration files (YAML) with no new Ginkgo e2e tests added. Custom check is not applicable to configuration-only changes.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI configuration YAML, not test code. No new Ginkgo e2e tests added; check requires test additions to apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI test configuration files to set an environment variable for test jobs; no deployment manifests, operator code, controllers, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration (YAML files). OTE Binary Stdout Contract check applies to Go code; no code changes present in this PR.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only an environment variable to existing CI job configurations; no new Ginkgo e2e tests are added, making this IPv6/disconnected check not applicable.
No-Weak-Crypto ✅ Passed PR contains only CI configuration changes (YAML environment variables), no cryptographic code, algorithms, or secret handling implementations to check against no-weak-crypto policy.
Container-Privileges ✅ Passed The PR only adds an environment variable override (OPCT_CLI_IMAGE) to CI job definitions. No privileged container settings, security context configurations, or capability escalations are introduced.
No-Sensitive-Data-In-Logs ✅ Passed PR adds only a Docker image reference (quay.io/opct/opct:latest) to CI config env variables—no logging statements or sensitive data exposure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hi @redhat-chai-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from sosiouxme and xueqzhan June 8, 2026 14:01
@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/assign

@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2026
@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Request created from Slack thread

@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mtulio, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout base SHA a61f2fe79c2a4e27f89067f0f17efdd29b5d3029: error checking out "a61f2fe79c2a4e27f89067f0f17efdd29b5d3029": exit status 128 fatal: unable to read tree (a61f2fe79c2a4e27f89067f0f17efdd29b5d3029)

Add OPCT_CLI_IMAGE=quay.io/opct/opct:latest to the existing OPCT
periodic jobs in the nightly-5.0 config to pick up the latest OPCT
bug fixes and visibility improvements from master:

- opct-platform-external-aws-ccm
- opct-platform-external-aws
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws-ccm N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

I can see the rehearsal job fetching latest image as well I can see UI bug fixes here - available only in latest.

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 8, 2026
@mtulio

mtulio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtulio, redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign mandre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants