Skip to content

HYPERFLEET-1196 - chore: add sherine-k to OWNERS#80237

Closed
rafabene wants to merge 1 commit into
openshift:mainfrom
rafabene:HYPERFLEET-1196-add-sherine-k-to-owners
Closed

HYPERFLEET-1196 - chore: add sherine-k to OWNERS#80237
rafabene wants to merge 1 commit into
openshift:mainfrom
rafabene:HYPERFLEET-1196-add-sherine-k-to-owners

Conversation

@rafabene

@rafabene rafabene commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add sherine-k to OWNERS file (approvers and reviewers)
  • New team member onboarding for Prow-based code review workflows

Related

Summary by CodeRabbit

This PR grants the GitHub user sherine-k reviewer and approver permissions across OpenShift CI configuration for Hyperfleet-related step-registry items and their associated job metadata. Changes are metadata-only (OWNERS / owners.* lists) and affect Prow-based code review flows for the impacted CI/job definitions.

What changed in practical terms:

  • Added "sherine-k" to approvers and reviewers in ci-operator/step-registry/hyperfleet/OWNERS.
  • Added "sherine-k" to approvers and reviewers across multiple openshift-hyperfleet step-registry files (chart-deployment and several e2e setup/cleanup/test workflow metadata JSON/YAML refs).
  • Some files also add "ldornele" and remove several prior owner entries (numeric handle 86254860 and usernames such as xueli181114, yasun1, yingzhanredhat, tzhou5) where noted.

Scope & impact:

  • Affects OpenShift CI configuration for Hyperfleet step-registry items and related CI job metadata. After merge, sherine-k will be able to review and approve PRs that modify these OWNERS-controlled CI/job configuration files.
  • Changes are non-functional metadata updates; no code, APIs, or runtime behavior were modified.

Review notes:

  • Files changed are ownership/metadata only; estimated review effort ranges low→medium depending on file count. The PR includes a "/retest" comment to retrigger CI.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 865587f2-9edc-4d4e-a375-34ce9eba77e3

📥 Commits

Reviewing files that changed from the base of the PR and between bf2e3b3 and 00eb6dc.

📒 Files selected for processing (8)
  • ci-operator/step-registry/hyperfleet/OWNERS
  • ci-operator/step-registry/openshift-hyperfleet/OWNERS
  • ci-operator/step-registry/openshift-hyperfleet/chart-deployment/openshift-hyperfleet-chart-deployment-ref.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/e2e/cleanup/cloud-provider/openshift-hyperfleet-e2e-cleanup-cloud-provider-ref.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/e2e/cleanup/cluster-resources/openshift-hyperfleet-e2e-cleanup-cluster-resources-ref.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/e2e/openshift-hyperfleet-e2e-workflow.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/e2e/setup/openshift-hyperfleet-e2e-setup-ref.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/e2e/test/openshift-hyperfleet-e2e-test-ref.metadata.json
✅ Files skipped from review due to trivial changes (3)
  • ci-operator/step-registry/openshift-hyperfleet/e2e/openshift-hyperfleet-e2e-workflow.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/e2e/cleanup/cluster-resources/openshift-hyperfleet-e2e-cleanup-cluster-resources-ref.metadata.json
  • ci-operator/step-registry/hyperfleet/OWNERS
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/step-registry/openshift-hyperfleet/chart-deployment/openshift-hyperfleet-chart-deployment-ref.metadata.json
  • ci-operator/step-registry/openshift-hyperfleet/OWNERS

Walkthrough

Adds sherine-k (and ldornele in some refs) to approvers and reviewers and removes several prior handles across hyperfleet and openshift-hyperfleet OWNERS and related metadata reference files.

Changes

Ownership metadata updates

Layer / File(s) Summary
Hyperfleet OWNERS updates
ci-operator/step-registry/hyperfleet/OWNERS
Added ldornele and sherine-k to the approvers and reviewers lists.
OpenShift-Hyperfleet OWNERS updates
ci-operator/step-registry/openshift-hyperfleet/OWNERS
Added sherine-k to approvers and reviewers and removed prior entries (including 86254860, xueli181114, yasun1, yingzhanredhat, tzhou5).
Chart-deployment metadata ref
ci-operator/step-registry/openshift-hyperfleet/chart-deployment/openshift-hyperfleet-chart-deployment-ref.metadata.json
Inserted sherine-k into owners.approvers and owners.reviewers, removed listed prior handles.
E2E cleanup — cloud-provider
ci-operator/step-registry/openshift-hyperfleet/e2e/cleanup/cloud-provider/openshift-hyperfleet-e2e-cleanup-cloud-provider-ref.metadata.json
Added sherine-k to owners.approvers and owners.reviewers; removed prior handles.
E2E cleanup — cluster-resources
ci-operator/step-registry/openshift-hyperfleet/e2e/cleanup/cluster-resources/openshift-hyperfleet-e2e-cleanup-cluster-resources-ref.metadata.json
Added sherine-k to owners.approvers and owners.reviewers; removed prior handles.
E2E workflow metadata ref
ci-operator/step-registry/openshift-hyperfleet/e2e/openshift-hyperfleet-e2e-workflow.metadata.json
Inserted sherine-k into owners.approvers and owners.reviewers, removed listed prior handles.
E2E setup metadata ref
ci-operator/step-registry/openshift-hyperfleet/e2e/setup/openshift-hyperfleet-e2e-setup-ref.metadata.json
Added sherine-k and ldornele to owners.approvers and owners.reviewers; removed prior handles.
E2E test metadata ref
ci-operator/step-registry/openshift-hyperfleet/e2e/test/openshift-hyperfleet-e2e-test-ref.metadata.json
Added sherine-k and ldornele to owners.approvers and owners.reviewers; removed prior handles.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

lgtm, jira/valid-reference

Suggested reviewers

  • jmguzik
  • bear-redhat
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding sherine-k to OWNERS files across multiple CI operator step registry locations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only OWNERS and metadata.json configuration changes with no Go test files or Ginkgo test definitions, so the check for stable Ginkgo test names is not applicable.
Test Structure And Quality ✅ Passed This PR modifies only OWNERS files and CI metadata/configuration files for the hyperfleet project. No Ginkgo test code was added or modified. The check is not applicable to this PR.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added. PR only modifies OWNERS and metadata JSON files, making the test compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added in this PR. Changes are limited to OWNERS files and metadata.json configuration updates for team onboarding purposes. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only OWNERS files and metadata.json files for code review workflows, not deployment manifests, operator code, or controllers with scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR modifies only configuration files (OWNERS) and metadata JSON files. No executable code, main functions, or test binaries are modified. OTE Binary Stdout Contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds no new Ginkgo e2e tests; only updates OWNERS files and metadata.json ownership lists for existing workflow registries. IPv6/disconnected network check is not applicable.
No-Weak-Crypto ✅ Passed PR contains only OWNERS and metadata.json configuration changes for team onboarding; no cryptographic code, weak crypto algorithms, or secret comparisons present.
Container-Privileges ✅ Passed PR modifies only OWNERS and metadata.json files for team onboarding. No K8s manifests with privileged container settings found in scope.
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies OWNERS and metadata files with GitHub usernames; no logging code or sensitive data is present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from ciaranRoche and crizzo71 June 8, 2026 16:32
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 8, 2026
@rafabene

rafabene commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@rafabene rafabene force-pushed the HYPERFLEET-1196-add-sherine-k-to-owners branch from 2ea59ae to 1bd8dd2 Compare June 8, 2026 16:45

@pnguyen44 pnguyen44 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@pnguyen44: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rafabene rafabene force-pushed the HYPERFLEET-1196-add-sherine-k-to-owners branch 2 times, most recently from bf2e3b3 to 00eb6dc Compare June 8, 2026 17:22
@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 8, 2026
@rafabene

rafabene commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/verify-owners

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • ldornele
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • ci-operator/step-registry/hyperfleet/OWNERS
    • ci-operator/step-registry/openshift-hyperfleet/OWNERS

@rafabene rafabene closed this Jun 8, 2026
@rafabene rafabene force-pushed the HYPERFLEET-1196-add-sherine-k-to-owners branch from 00eb6dc to a244429 Compare June 8, 2026 17:55
@rafabene

rafabene commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/verify-owners

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rafabene, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 0495df244a0d6b561d1970d05e9a8cb27b472763 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rafabene rafabene deleted the HYPERFLEET-1196-add-sherine-k-to-owners branch June 8, 2026 17:57
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pnguyen44, rafabene
Once this PR has been reviewed and has the lgtm label, please assign hector-vido for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@rafabene: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config a244429 link true /test generated-config
ci/prow/openshift-image-mirror-mappings a244429 link true /test openshift-image-mirror-mappings
ci/prow/owners a244429 link true /test owners
ci/prow/ci-operator-registry a244429 link true /test ci-operator-registry
ci/prow/core-valid a244429 link true /test core-valid
ci/prow/check-gh-automation a244429 link true /test check-gh-automation
ci/prow/prow-config-filenames a244429 link true /test prow-config-filenames
ci/prow/ci-operator-config a244429 link true /test ci-operator-config
ci/prow/ci-operator-config-metadata a244429 link true /test ci-operator-config-metadata
ci/prow/release-controller-config a244429 link true /test release-controller-config
ci/prow/yamllint a244429 link true /test yamllint
ci/prow/ordered-prow-config a244429 link true /test ordered-prow-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants