ROSAENG-59283 | prow onboarding for ams#80255
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cambelem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-ci
Bot
added
the
do-not-merge/invalid-owners-file
cambelem
force-pushed
the
rosaeng-59283-prow-onboard-rosa-account-manager-service
branch
from
bacd846 to
e321bba
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughOnboards openshift-online/rosa-account-manager-service by adding an OWNERS file, a ci-operator job for building/testing the service, and repository-specific Prow plugin and Tide configuration for PR automation. ChangesService Infrastructure Onboarding
Sequence Diagram(s)(omitted — configuration-only changes without a multi-component sequential runtime flow) Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cambelem
force-pushed
the
rosaeng-59283-prow-onboard-rosa-account-manager-service
branch
from
e321bba to
8b24105
Compare
|
/verify-owners |
openshift-ci
Bot
removed
the
do-not-merge/invalid-owners-file
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master.yaml (1)
1-36:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing generated Prow job files.
According to the repository guidelines, after modifying CI configuration files in
ci-operator/config/, you must runmake updateto regenerate downstream artifacts, including Prow job configurations inci-operator/jobs/.This PR should include generated job files at:
ci-operator/jobs/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master-presubmits.yamlci-operator/jobs/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master-postsubmits.yaml(if applicable)Please run
make updatefrom the repository root and commit the generated files.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master.yaml` around lines 1 - 36, The CI config change adds/updates top-level keys like binary_build_commands, test_binary_build_commands and zz_generated_metadata but you didn't regenerate the downstream Prow job artifacts; run make update at the repository root to regenerate ci-operator/jobs for the openshift-online rosa-account-manager-service (which will create the master-presubmits and master-postsubmits YAMLs) and commit those generated files alongside this CI config change.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master.yaml`:
- Around line 2-6: The build_root image_stream_tag references a non-existent tag
(name: release, namespace: openshift, tag: golang-1.25); update the
build_root.image_stream_tag.tag value to a golang imagestreamtag that actually
exists in the openshift namespace (or adjust the name/namespace to match the
available imagestreamtag), e.g., query available tags with oc get imagestreamtag
release -n openshift and replace golang-1.25 with one of the returned tags so
build_root points to a valid imagestreamtag.
In `@ci-operator/config/openshift-online/rosa-account-manager-service/OWNERS`:
- Around line 1-10: The OWNERS file's approvers/reviewers lists contain GitHub
handles that are either non-existent or not public members of the
openshift-online org; update the approvers and reviewers entries in
ci-operator/config/openshift-online/rosa-account-manager-service/OWNERS by
removing the invalid handles (ecambel, ehimmelr, bhthakur, xamorim) and
replacing them with GitHub usernames that exist and are confirmed public members
of the openshift-online organization; ensure both the approvers and reviewers
blocks list only valid org members and rerun the owners validation to confirm
the file no longer triggers do-not-merge/invalid-owners-file.
---
Outside diff comments:
In
`@ci-operator/config/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master.yaml`:
- Around line 1-36: The CI config change adds/updates top-level keys like
binary_build_commands, test_binary_build_commands and zz_generated_metadata but
you didn't regenerate the downstream Prow job artifacts; run make update at the
repository root to regenerate ci-operator/jobs for the openshift-online
rosa-account-manager-service (which will create the master-presubmits and
master-postsubmits YAMLs) and commit those generated files alongside this CI
config change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 10faa357-475e-45b5-933f-a1336486265b
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-online/rosa-account-manager-service/OWNERSis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift-online/rosa-account-manager-service/OWNERSci-operator/config/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master.yamlcore-services/prow/02_config/openshift-online/rosa-account-manager-service/_pluginconfig.yamlcore-services/prow/02_config/openshift-online/rosa-account-manager-service/_prowconfig.yaml
| build_root: | ||
| image_stream_tag: | ||
| name: release | ||
| namespace: openshift | ||
| tag: golang-1.25 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if golang-1.25 image stream tag exists in openshift namespace
oc get imagestreamtag release:golang-1.25 -n openshift 2>/dev/null && \
echo "✓ golang-1.25 tag exists" || \
echo "✗ golang-1.25 tag not found - consider using golang-1.23 or golang-1.22"
# List available golang tags
echo -e "\nAvailable golang tags:"
oc get imagestream release -n openshift -o json 2>/dev/null | \
jq -r '.spec.tags[]? | select(.name | startswith("golang")) | .name' | sort -VRepository: openshift/release
Length of output: 157
🌐 Web query:
OpenShift CI golang builder image tags available in 2026
💡 Result:
As of June 2026, OpenShift CI uses builder images hosted in the registry.ci.openshift.org/ocp/builder repository [1]. These images typically follow a structured naming convention: registry.ci.openshift.org/ocp/builder:rhel-{VERSION}-golang-{GO_VERSION}-openshift-{OCP_VERSION} As of early 2026, recent technical documentation and source code updates confirm the availability and usage of Go 1.25 builder images, commonly paired with OpenShift 4.22 base images [2][3][4][5][6]. Key naming patterns for these images include: - RHEL Version: Commonly rhel-9 (e.g., rhel-9-golang-1.25-openshift-4.22) [2][5]. RHEL-8 variants also exist and are updated in parallel for specific components (e.g., rhel-8-golang-1.25-openshift-4.22) [5]. - Golang Version: As of March/April 2026, Go 1.25 is the standard for new builds in many core OpenShift repositories [3][4][5][6]. - OpenShift Version: These images are tagged against specific OpenShift release streams, such as 4.22 [2][3][5][6]. Additionally, CI configurations often utilize "release" images for the build root, following a similar pattern: registry.ci.openshift.org/openshift/release:rhel-{VERSION}-release-golang-{GO_VERSION}-openshift-{OCP_VERSION} [1][3][4][5][6]. You can verify the current tags by querying the imagestreams in the OpenShift CI registry or by checking the build manifest configurations (.ci-operator.yaml) of official OpenShift repositories, which are regularly updated to reflect the latest stable builder tags [1][2][6].
Citations:
- 1: https://docs.ci.openshift.org/architecture/images/
- 2: NO-JIRA: Bump to builder:rhel-9-golang-1.25-openshift-4.22 cluster-version-operator#1293
- 3: openshift/cluster-image-registry-operator@1eb03dc
- 4: openshift/api@c63fe74
- 5: openshift/oc@b0c5ec0
- 6: openshift/operator-framework-operator-controller@e7fb1ec
Update build_root golang tag to an existing imagestreamtag
The config references release:golang-1.25 in the openshift namespace, but oc get imagestreamtag release:golang-1.25 -n openshift returns not found. Switch to a golang imagestreamtag that exists in that namespace (or align the config with the actual available release tags).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-online/rosa-account-manager-service/openshift-online-rosa-account-manager-service-master.yaml`
around lines 2 - 6, The build_root image_stream_tag references a non-existent
tag (name: release, namespace: openshift, tag: golang-1.25); update the
build_root.image_stream_tag.tag value to a golang imagestreamtag that actually
exists in the openshift namespace (or adjust the name/namespace to match the
available imagestreamtag), e.g., query available tags with oc get imagestreamtag
release -n openshift and replace golang-1.25 with one of the returned tags so
build_root points to a valid imagestreamtag.
8b24105 to
7f35b7a
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/retest |
|
@cambelem: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cambelem
force-pushed
the
rosaeng-59283-prow-onboard-rosa-account-manager-service
branch
from
7f35b7a to
b1f57cf
Compare
1 participant
Onboarding account manager service for prow.
Summary by CodeRabbit
This PR onboards the openshift-online/rosa-account-manager-service repository into OpenShift CI (Prow) by adding CI operator configuration, OWNERS, Prow plugin configuration, and Tide merge rules so the repo can use shared OpenShift CI automation.
Practical impact and key changes:
CI build & tests (ci-operator config):
go install ./cmd/account-manager.go test ./pkg/... ./cmd/... ./test/....bincontainer: unit-test (make test), integration-test (make test-integration), fedramp-test (make test-fedramp), xcm-test (make test-xcm).OWNERS:
Prow plugins & external plugins (_pluginconfig.yaml):
Tide configuration (_prowconfig.yaml):
Review effort: Low–Medium. OWNERS change is small; ci-operator and Prow/plugin config should be reviewed to validate job commands, resources, and external-plugin endpoints.