Skip to content
Commits on Apr 22, 2016
  1. @openshift-bot

    Merge pull request #750 from thrasher-redhat/dependencyfix

    Merged by openshift-bot
    openshift-bot committed Apr 22, 2016
  2. @thrasher-redhat

    Modifying rhc to focus on support for ruby1.8.7

    With Ruby 1.8.7 and 1.9.3 being deprecated, many gems are dropping support for
    these older versions of Ruby.  These dependencies make it impossible for rhc to
    support leveraging rhc on both Ruby 1.8.7 and newer Ruby 2.x versions at the
    same time.  With the upcoming move towards OpenShift v3 - we will be focusing
    support on rhc built with Ruby 1.8.7.  This version of rhc may work with newer
    versions of ruby, but the primary support will be 1.8.7.
    
    Conditional building options have been added.  These will use the correct
    dependencies at build time for the ruby version being used.  The standard rhc
    gem from rubygems.org is built with Ruby 1.8.7, which can run into dependency
    issues when running rhc with later versions of Ruby.  Users can build rhc from
    source on the system in question to use the correct dependencies for their Ruby
    version.
    thrasher-redhat committed Mar 30, 2016
Commits on Feb 8, 2016
  1. @openshift-bot

    Merge pull request #746 from sallyom/remove.gem-add-to-.gitignore

    Merged by openshift-bot
    openshift-bot committed Feb 8, 2016
Commits on Feb 3, 2016
  1. @sallyom
Commits on Jan 29, 2016
  1. @openshift-bot

    Merge pull request #743 from sallyom/bz1294401

    Merged by openshift-bot
    openshift-bot committed Jan 29, 2016
  2. @sallyom

    update search path for 'ssh.exe'

    bz 1294401
    bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1294401
    
    'rhc ssh <app>' fails with Windows 10 Home Edition because rhc does
    not recognize 'C:\Program Files\Git\usr\bin\ssh.exe' as a possible
    location for 'ssh.exe'.  Updated to add this path.  Also, updated the
    Git install site recommendation since the current site is obsolete.
    sallyom committed Jan 21, 2016
Commits on Jan 28, 2016
  1. @openshift-bot

    Merge pull request #742 from sallyom/bzquota

    Merged by openshift-bot
    openshift-bot committed Jan 28, 2016
Commits on Jan 23, 2016
  1. @sallyom

    'rhc app show <app> --gears quota' use 'quota' not 'du'

    Bug 1109935
    Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1109935
    
    Users expect 'rhc app show <app> --gears quota' to display output of the system 'quota' cmd.
    Currently, the rhc cmd uses 'du -s'.  This PR replaces 'du' with 'quota'
    sallyom committed Jan 19, 2016
Commits on Jan 8, 2016
  1. @openshift-bot

    Merge pull request #738 from thrasher-redhat/bug1156328

    Merged by openshift-bot
    openshift-bot committed Jan 8, 2016
  2. @openshift-bot

    Merge pull request #741 from dinhxuanvu/jenkins-gear

    Merged by openshift-bot
    openshift-bot committed Jan 8, 2016
  3. @dinhxuanvu

    Bug 1111456 - jenkins app default to small gear with enable-jenkins a…

    …nd custom gear size
    
    When user creates app using rhc with --enable-jenkins and medium --gear-size
    options, the jenkins app is deployed onto default small gear size.
    
    The rhc code doesn't pass the gear size option during jenkins app creattion.
    This commit will modify the code to allow the gear size value to be passed
    into method that create jenkins app.
    
    Bug 1111456
    Link <https://bugzilla.redhat.com/show_bug.cgi?id=1111456>
    
    Signed-off-by: Vu Dinh <vdinh@redhat.com>
    dinhxuanvu committed Jan 6, 2016
Commits on Dec 23, 2015
  1. @thrasher-redhat

    helpers.rb: remove sslv3 output from error message

    Bug 1156382
    BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1156382
    
    Ruby still provides support for sslv3, sslv2, and sslv23 (sslv3 with dropback to
    sslv2).  These versions of ssl are not supported with openshift, and shouldn't
    be shown as valid options to he user.  The error mesage will now remove ssl
    options from the output to avoid conflicting information to the user.
    thrasher-redhat committed Dec 23, 2015
Commits on Dec 17, 2015
  1. @openshift-bot

    Merge pull request #723 from Miciah/deobfuscate-dns_propagated

    Merged by openshift-bot
    openshift-bot committed Dec 17, 2015
  2. @openshift-bot

    Merge pull request #729 from blueyed/fix-comp-for-bashcompinit

    Merged by openshift-bot
    openshift-bot committed Dec 17, 2015
Commits on Dec 11, 2015
  1. @openshift-bot

    Merge pull request #737 from tiwillia/portforwardagain

    Merged by openshift-bot
    openshift-bot committed Dec 11, 2015
  2. @tiwillia

    Include ssh url in example port-forward command

    When port forwarding with a custom ssh executable and the port collection fails, an example command will be provided to the user so they can manually forward the ports. This command was previously incomplete, as it did not include the ssh url of the application. This commit completes the example command.
    tiwillia committed Dec 11, 2015
Commits on Dec 9, 2015
  1. @openshift-bot

    Merge pull request #735 from tiwillia/rhcssherrors

    Merged by openshift-bot
    openshift-bot committed Dec 9, 2015
Commits on Dec 8, 2015
  1. @tiwillia

    Return a helpful error message if port-forward fails with custom ssh …

    …executable
    
    Bug 1177753
    https://bugzilla.redhat.com/show_bug.cgi?id=1177753
    
    Previously, if port-forward failed to run the custom ssh executable specified, only the output from the command run was displayed. After this change, a helpful message should be displayed that includes the output of the command run with the ssh executable.
    tiwillia committed Dec 7, 2015
Commits on Dec 3, 2015
  1. @openshift-bot

    Merge pull request #733 from tiwillia/rhcappdeployssh

    Merged by openshift-bot
    openshift-bot committed Dec 3, 2015
  2. @tiwillia

    Enable deployment operations to utilize a custom ssh executable

    Bug 1177753
    https://bugzilla.redhat.com/show_bug.cgi?id=1177753
    
    Deploying a git ref, binary file, or binary file url previously only used ruby's implementation of ssh through the `Net::SSH` library. After this change, these deployment operations will honor the `--ssh` global option or `ssh` configuration directive.
    
    Activating deployments will now also honor a custom ssh executable.
    
    Additionally, the tests have been heavily modifed. Previously, tests that test the various ways `rhc app deploy` is used were located in `spec/rhc/commands/deployment_spec.rb`. This spec file is meant to test `rhc deployment` commands. The new ssh executable code added to the DeploymentHelpers class could not be properly tested from `deployment_spec.rb`. All `rhc app deploy` tests have been moved to their proper home, `spec/rhc/commands/app.rb`, and modified to work appropriately.
    tiwillia committed Nov 30, 2015
  3. @openshift-bot

    Merge pull request #731 from dinhxuanvu/snapshot-save

    Merged by openshift-bot
    openshift-bot committed Dec 3, 2015
  4. @openshift-bot

    Merge pull request #724 from Miciah/gemspec-restore-net-ssh-lower-bound

    Merged by openshift-bot
    openshift-bot committed Dec 2, 2015
Commits on Dec 2, 2015
  1. @dinhxuanvu

    Bug 1141093 - rhc snapshot save same filename didn't prompt conflict …

    …warning
    
    The 'rhc snapshot save -f' command overwrites existing file without warning
    if user inputs same filename for two different apps.
    
    This commit modifies the rhc snapshow command to verify if the file already
    exists and ask user for confirmation before proceeding.
    
    Bug 1141093
    Link <https://bugzilla.redhat.com/show_bug.cgi?id=1141093>
    
    Signed-off-by: Vu Dinh <vdinh@redhat.com>
    dinhxuanvu committed Nov 25, 2015
Commits on Nov 26, 2015
  1. @openshift-bot

    Merge pull request #732 from tiwillia/rhcsshfix

    Merged by openshift-bot
    openshift-bot committed Nov 25, 2015
Commits on Nov 25, 2015
  1. @tiwillia

    When stderr is redirected to `/dev/null`, no output is seen from `rhc…

    … tail` and the command ends immediately. After this change, no redirection will occur when run on windows systems, resolving this issue.
    
    Additionally, the `rhc snapshot-save` and `rhc snapshot-restore` commands were suffering from the same issue. This has been resolved by, again, only adding the stderr redirection to `/dev/null` when not run on windows.
    
    Bug 1177753
    https://bugzilla.redhat.com/show_bug.cgi?id=1177753
    tiwillia committed Nov 25, 2015
Commits on Nov 17, 2015
  1. @openshift-bot

    Merge pull request #728 from dinhxuanvu/ssh-permission

    Merged by openshift-bot
    openshift-bot committed Nov 17, 2015
Commits on Nov 16, 2015
  1. @openshift-bot

    Merge pull request #727 from dinhxuanvu/rhc-apps

    Merged by openshift-bot
    openshift-bot committed Nov 16, 2015
  2. @dinhxuanvu

    Bug 1163050 - Fix exception using rhc app ssh --ssh with custom path

    The rhc app ssh --ssh with custom and exist path fails due to lacking
    of checking whether the path is a readable file or not.
    
    This commit modifies check_ssh_executable? method to check if the path
    is a readable file or not and it no longer accepted directory as a
    valid input. A exception is raised in case of unreadable/non existent
    file or directory is provided.
    
    Bug 1163050
    Link <https://bugzilla.redhat.com/show_bug.cgi?id=1163050>
    
    Signed-off-by: Vu Dinh <vdinh@redhat.com>
    dinhxuanvu committed Nov 16, 2015
  3. @dinhxuanvu

    Bug 1164699 - Avoid using --summary and --verbose together for `rhc a…

    …pps`
    
    If -s/--sumary and -v/--verbose options are used together in rhc apps,
    the verbose option is ignored and only --summary option is executed.
    
    This commmit adds an info output to notify user that both options are
    used and advise user to use only one at a time.
    
    Bug 1164699
    Link <https://bugzilla.redhat.com/show_bug.cgi?id=1164699>
    
    Signed-off-by: Vu Dinh <vdinh@redhat.com>
    dinhxuanvu committed Nov 14, 2015
  4. @blueyed

    Fix rhc_bash for usage with Zsh's bashcompinit

    "${COMP_WORDS[@]:0:COMP_CWORD}" and
    "${COMP_WORDS[@]:0:$COMP_CWORD}" are the same in bash, but not in Zsh.
    
    This commit fixes an error when the bash completion is used with Zsh's
    bashcompinit compatibility wrapper, e.g.
    
    > _rhc:14: unrecognized modifier 'C'
    
    ```
    bash_source() {
      alias shopt=':'
      alias _expand=_bash_expand
      alias _complete=_bash_comp
      emulate -R -L sh
      setopt kshglob noshglob braceexpand
      setopt kshglob
    
      have() {
        unset have
        (( ${+commands[$1]} )) && have=yes
      }
    
      source "$@"
    }
    bash_completions=()
    if [ -n "$commands[rhc]" ] ; then
      bash_completions+=(/home/user/.gem/ruby/2.2.0/gems/rhc-1.38.4/autocomplete/rhc_bash)
    fi
    if (( $#bash_completions )); then
      echo "Loading bash completion system for: ${bash_completions:t}"
      if [[ -z "$functions[complete]" ]]; then
        autoload -Uz bashcompinit
        bashcompinit
      fi
      for i in $bash_completions; do
        bash_source $i
      done
    fi
    ```
    
    Fixes #697.
    blueyed committed Nov 16, 2015
Commits on Nov 9, 2015
  1. @openshift-bot

    Merge pull request #705 from tiwillia/1263373

    Merged by openshift-bot
    openshift-bot committed Nov 9, 2015
  2. @tiwillia

    Allow an ssh executable to be specified globally

    Bug 1177753
    https://bugzilla.redhat.com/show_bug.cgi?id=1177753
    
    Previously, a `--ssh` option could be passed to a few subcommands to use a seperate ssh executable other than that found in the default PATH. After this commit, this option is now a global options used in all commands utilizing ssh. A `ssh` option is now available in configuration that allows this global option to be set persistently.
    
    The snapshot-restore, snapshot-save, and tail commands will now use the an ssh executable if specified. If no ssh executable is specified, the Net::SSH implementations will continue to be used.
    
    The port-forward command will not attempt to actually forward ports with a custom ssh executable. This is due to how errors reported from a custom ssh executable are unpredictable. If one or more of the port-forwards fails, the error reported is not predictable enough to script a workaround or helpful error message. If a custom ssh executable is specified when port-forward is called, rhc will use the custom ssh executable to gather the ports and services that will need to be forwarded from the application. It will then use this information to construct a command that the user can run to forward the ports themselves. The command structure assumes that the ssh executable uses the same flags as openSSH.
    
    The scp command will not attempt to use any ssh executable. Instead, a helpful error will be reported with an scp command. The user can use the command to upload/download the file themselves. If the client is on windows, no scp command is provided since we cannot assume that the client has an scp executable available. Instead, a helpful error message will be provided instructing the user to investigate 3rd-party alternatives such as FileZilla and WinSCP.
    tiwillia committed Oct 14, 2015
  3. @openshift-bot

    Merge pull request #720 from Miciah/cucumber-slash-README.md-fix-typo…

    …-cucummber
    
    Merged by openshift-bot
    openshift-bot committed Nov 9, 2015
Commits on Nov 8, 2015
  1. @openshift-bot

    Merge pull request #718 from Miciah/rhc-server-fix-typo-estabilished

    Merged by openshift-bot
    openshift-bot committed Nov 7, 2015
  2. @openshift-bot

    Merge pull request #700 from Miciah/quote-as-necessary-when-writing-c…

    …onfiguration
    
    Merged by openshift-bot
    openshift-bot committed Nov 7, 2015
Something went wrong with that request. Please try again.