Permalink
Switch branches/tags
Commits on Mar 26, 2013
  1. Fix Bug 920059

    BanzaiMan committed Mar 26, 2013
    * When the public key does not exist, put the error message for debugging, not to STDERR.
    * Instead, warn the user when the public key does not exist--only once.
    * Includes a corresponding change to the spec, since there is no output to STDERR.
Commits on Mar 14, 2013
  1. This spec now passes.

    BanzaiMan committed Mar 14, 2013
  2. Bug 920028.

    BanzaiMan committed Mar 14, 2013
    Notice that we override Commander::Command#parse_options_and_call_procs
      - in particular, we add '--help' as a valid command option when '--h'
        is passed.
      - note that '--h' exists in @args for the present RHC::CommandRunner,
        but it is not removed from @args in #run!.
      - #run! calls Command#run, which ends up calling
        Command#parse_options_and_call_procs, which adds '--help' again,
        since '--h' was not removed from @args, and thus passed back to
        parse_options_and_call_procs.
      - Infinite recursion ensues.
      - So, we need to defend ourselves by removing all potential matches
        for the command option '--help'.
Commits on Mar 12, 2013
  1. Add spec for Bug 920028.

    BanzaiMan committed Mar 12, 2013
Commits on Mar 6, 2013
  1. Wrap it up in paragraph

    BanzaiMan committed Mar 6, 2013
  2. Bug 917605

    BanzaiMan committed Mar 6, 2013
    Tweak port forwarding output header to clarify the intention
  3. Bug 917457

    BanzaiMan committed Mar 6, 2013
    When a local port is already bound by another process, we see
    Errno::EACCES. Rescue this and try the next port.
Commits on Mar 4, 2013
  1. Get around FakeFS bug (fakefs/fakefs#177)

    BanzaiMan committed Mar 4, 2013
    By stubbing the #cp call so that it will create the necessary
    FS entry.
Commits on Feb 28, 2013
  1. Bug 916122: Avoid misleading port-forwarding specification for MySQL.

    BanzaiMan committed Feb 28, 2013
    mysql client forces UNIX socket if the host is specified as 'localhost'.
    Avoid this by displaying the numeric IP.
Commits on Feb 7, 2013
  1. Use 'localhost' exclusively for local port forwarding.

    BanzaiMan committed Feb 7, 2013
    This should fix bug 907742. The behavior change is large enough,
    however, that existing documents should be revised.
Commits on Feb 6, 2013
  1. Bug 907742

    BanzaiMan committed Feb 6, 2013
    Fix port forwarding specification matching by relaxing the regular expression to match 'rhc-list-ports' output.
Commits on Feb 5, 2013
  1. Clean up

    BanzaiMan committed Feb 5, 2013
  2. Specs for RHC::Helpers.hosts_file_contains?

    BanzaiMan committed Feb 5, 2013
    Code coverage should be complete.
Commits on Feb 4, 2013
  1. Spec for Bug 903403.

    BanzaiMan committed Feb 4, 2013
  2. Tweak error message.

    BanzaiMan committed Feb 4, 2013
    Also, do not treat ResolvError any dfiferently from any other StandardError.
  3. Bug 903403

    BanzaiMan committed Feb 4, 2013
    It is suspected that host name resolution can fail in /etc/hosts under some circumstances.
    We aim to work around this problem by forcing an tolerant encoding when using the Hosts resolver.
Commits on Jan 25, 2013
  1. Fix RHC Extended test failures.

    BanzaiMan committed Jan 25, 2013
    Due to the recent model refactoring on the broker, we no longer create TXT DNS records.
    This is used in the "Then" clauses of the failing Cucumber scenarios, which should now simply return true.
Commits on Jan 23, 2013
  1. Put code where they belong.

    BanzaiMan committed Jan 23, 2013
  2. Fix up specs.

    BanzaiMan committed Jan 23, 2013
    wizard.rb: rest_client can be nil during the spec run
    wizard_spec.rb: set up stubs correctly at various stages of the spec runs so that wizard behaves correctly.
  3. Bug 903071: 'rhc setup' can show unexpected error message

    BanzaiMan committed Jan 23, 2013
    Indicate what exception is seen when SSH connection fails, so the
    message is more meaningful.
Commits on Jan 22, 2013
  1. Tests are not fatal.

    BanzaiMan committed Jan 22, 2013
Commits on Jan 21, 2013
  1. Make use of cache here

    BanzaiMan committed Jan 15, 2013