Modifying rhc to focus support on ruby1.8.7 #750
Conversation
|
[test], please! Possible things todo:
|
thrasher-redhat
force-pushed
the
dependencyfix
branch
3 times, most recently
from
c5bef91
to
eb3bc43
Compare
|
So since jenkins is testing with ruby 1.9.3, the addressable change is causing test failures. Need to see if these tests would fail with 1.8.7 (and addressable 2.3.2 or 2.3.8). Also may need to check the tests themselves to see if they are failures of functionality or if the test should be updated. |
thrasher-redhat
force-pushed
the
dependencyfix
branch
4 times, most recently
from
0e880aa
to
d1a0c8a
Compare
thrasher-redhat
changed the title
| @@ -30,7 +30,6 @@ Gem::Specification.new do |s| | |||
| sep | |||
| ].join("\n") | |||
|
|
|||
| s.add_dependency 'net-ssh', '>= 2.0.11', '<= 2.9.2' | |||
| s.add_dependency 'net-scp', '>= 1.1.2' | |||
| s.add_dependency 'net-ssh-multi','>= 1.2.0' | |||
| s.add_dependency 'archive-tar-minitar' | |||
There was a problem hiding this comment.
Didn't we want to lock down versions for all dependencies to the latest known working version? Or do we not mind handling locking them down once a version is released that breaks us?
There was a problem hiding this comment.
I'm pretty sure in our meeting Dan said that locking EVERY version of EVERY dependency to a known good one would take a lot more effort than its worth.
There was a problem hiding this comment.
Okay, I'm fine with this then. We just need to be aware that it is possible for the unlocked gems to cause issues in the future with updates.
thrasher-redhat
force-pushed
the
dependencyfix
branch
from
d1a0c8a
to
de3b1f8
Compare
With Ruby 1.8.7 and 1.9.3 being deprecated, many gems are dropping support for these older versions of Ruby. These dependencies make it impossible for rhc to support leveraging rhc on both Ruby 1.8.7 and newer Ruby 2.x versions at the same time. With the upcoming move towards OpenShift v3 - we will be focusing support on rhc built with Ruby 1.8.7. This version of rhc may work with newer versions of ruby, but the primary support will be 1.8.7. Conditional building options have been added. These will use the correct dependencies at build time for the ruby version being used. The standard rhc gem from rubygems.org is built with Ruby 1.8.7, which can run into dependency issues when running rhc with later versions of Ruby. Users can build rhc from source on the system in question to use the correct dependencies for their Ruby version.
thrasher-redhat
force-pushed
the
dependencyfix
branch
from
de3b1f8
to
3fb8f05
Compare
|
Now with 100% more backticks! |
|
Evaluated for online test up to 3fb8f05 |
|
Lovely jubbly! openshift-bot, please [merge]! |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6727/) (Image: devenv_5786) |
|
Evaluated for online merge up to 3fb8f05 |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9274/) |
With Ruby 1.8.7 and 1.9.3 being deprecated, many gems are dropping support for
them. These dependencies make it impossible for rhc to support both Ruby 1.8.7
and newer Ruby 2.x versions at the same time. With the upcoming move towards
OpenShift v3 - we will be focusing support on Ruby 1.8.7. We're going to try to
support as far forward as possible without breaking rhc on Ruby 1.8.7.