Bug 1903206: Add unit tests to verify NotReadyAddresses in EndpointSlices

[frobware]

Moved the existing utility function into endpointsubset package. Added
unit tests to assert on EndpointSlices having Ready/NotReady
conditions.

Follow on from #229

[openshift-ci-robot]

@frobware: This pull request references Bugzilla bug 1903206, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1903206: Add unit tests to verify NotReadyAddresses in EndpointSlices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

/bugzilla refresh

[openshift-ci-robot]

@frobware: This pull request references Bugzilla bug 1903206, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@frobware: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sgreene570]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [frobware,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[frobware]

test failures:

failed to acquire lease: resources not found

/retest

[openshift-ci-robot]

@frobware: All pull requests linked via external trackers have merged:

• openshift/router#229
• openshift/router#231

Bugzilla bug 1903206 has been moved to the MODIFIED state.

In response to this:

Bug 1903206: Add unit tests to verify NotReadyAddresses in EndpointSlices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@frobware: #231 failed to apply on top of branch "release-4.6":

Applying: Add unit tests to verify NotReadyAddresses in EndpointSlices
Using index info to reconstruct a base tree...
M	pkg/router/controller/router_controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/router/controller/router_controller.go
CONFLICT (content): Merge conflict in pkg/router/controller/router_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add unit tests to verify NotReadyAddresses in EndpointSlices
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[frobware]

package endpointsubset

Although this has merged I disagree. In general always test the public API, using _test was a deliberate choice.

[frobware]

				t.Errorf("ConvertEndpointSlice() failed (-got +want):\n%s", diff)

@frobware: #231 failed to apply on top of branch "release-4.6":

Applying: Add unit tests to verify NotReadyAddresses in EndpointSlices
Using index info to reconstruct a base tree...
M	pkg/router/controller/router_controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/router/controller/router_controller.go
CONFLICT (content): Merge conflict in pkg/router/controller/router_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add unit tests to verify NotReadyAddresses in EndpointSlices
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

The cherry-pick needs #230

[frobware]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@frobware: new pull request created: #232

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

package endpointsubset

Although this has merged I disagree. In general always test the public API, using _test was a deliberate choice.

Interesting. I didn't realize that that was allowed, but

% go help test
usage: go test [build/test flags] [packages] [build/test flags & test binary flags]

[...]

Test files that declare a package with the suffix "_test" will be compiled as a
separate package, and then linked and run with the main test binary.

https://stackoverflow.com/questions/19998250/proper-package-naming-for-testing-with-the-go-language

TIL.