Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with RFC7239 for Forwarded header #8

Merged
merged 1 commit into from Jul 20, 2019
Merged

Comply with RFC7239 for Forwarded header #8

merged 1 commit into from Jul 20, 2019

Conversation

alexcern
Copy link
Contributor

proto-version may be empty when http/2 is not enabled (the default), and empty values
must be surrounded by quotes as per https://tools.ietf.org/html/rfc7239

Applications may fail to parse the header if not complying with the RFC

@alexcern
Comply with RFC7239 for Forwarded header
73fda93 
proto-version may be empty, and empty values
must be surrounded by quotes
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @alexcern. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2019
@alexcern
Copy link
Contributor Author

@ramr could you please take a look? Thanks!

ramr
ramr approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@ramr ramr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ironcladlou
Copy link
Contributor

/lgtm
/approve

Sorry for the delay!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcern, ironcladlou, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2019
@ironcladlou
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2019
@alexcern
Copy link
Contributor Author

/restest

@ironcladlou
Copy link
Contributor

/retest

1 similar comment
@ironcladlou
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 496902d into openshift:master Jul 20, 2019
@nak3 nak3 mentioned this pull request Jul 31, 2019
Merged
danehans added a commit to danehans/router that referenced this pull request Feb 17, 2020
@danehans
Bug 1803001: Reverts PR openshift#8
0f96455
@danehans danehans mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramr ramr ramr approved these changes

@pweil- pweil- Awaiting requested review from pweil-

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@ironcladlou ironcladlou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alexcern @openshift-ci-robot @ironcladlou @openshift-bot @ramr @openshift-merge-robot