Bug 1803001: Removes Unneeded proto-version Header

[danehans]

PR #8 incorrectly double quoted the proto-version field value, even when this value was empty. Per rfc7230 section-3.2.6, field values must consist of 1 character (1*tchar). During my investigation, I could not find any references for the proto-version header. This header appears to be unnecessary and is removed by this PR.

/assign @ironcladlou @Miciah

[openshift-ci-robot]

@danehans: This pull request references Bugzilla bug 1803001, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1803001: Removes Double Quotes From proto-version Field Value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danehans]

error: could not run steps: step e2e-aws failed: template pod "e2e-aws" failed: the pod ci-op-4m01std9/e2e-aws failed after 1m27s (failed containers: setup): ContainerFailed one or more containers exited

/test e2e-aws

[ironcladlou]

/approve

@Miciah PTAL and tag?

[Miciah]

Do you have a reference handy to the standard that specifies proto-version? I assume it would fall under https://tools.ietf.org/html/rfc7239#section-5.4 ("Extensions"), but is it explicitly defined in any standard?

[danehans]

@Miciah that appears to be the correct reference for the proto field. However, I can't find any references for proto-version. Is proto-version a valid header?

[Miciah]

I don't think it is. The header was added with HTTP/2 support in openshift/origin@a6edc17. I think we should just drop it. (We can keep X-Forwarded-Proto-Version though as the X- prefix indicates that it is non-standard.)

[openshift-ci-robot]

@danehans: This pull request references Bugzilla bug 1803001, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1803001: Removes Unneeded proto-version Header

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danehans]

/bugzilla refresh

[openshift-ci-robot]

@danehans: This pull request references Bugzilla bug 1803001, which is valid.

3 validation(s) run on this bug

- bug is open, matching expected state (open) - bug target release (4.5.0) matches configured target release for branch (4.5.0) - bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• images/router/OWNERS [Miciah,ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@danehans: All pull requests linked via external trackers have merged. Bugzilla bug 1803001 has been moved to the MODIFIED state.

In response to this:

Bug 1803001: Removes Unneeded proto-version Header

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.