Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1793952: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart #105

Conversation

@danwinship
Copy link
Contributor

danwinship commented Feb 6, 2020

backport of #96 and #103
/cc @juanluisvaladas

juanluisvaladas and others added 2 commits Jan 20, 2020
If a project has only a deny-all rule and pods running on it,
npNameSpace.inUse was set to false, this commit sets it to true.

If inUse is set to false, the node will not update the
npNamespace if new rules are created until new pods are created.

More details on BZ#1790440
VNID 0's rules should never be garbage-collected, so FindUnusedVNIDs()
needs to always consider it to be in use. But FindPolicyVNIDs() needs
to NOT have that special-case, or else it will get confused and think
it has already created the rules for VNID 0 when it actually hasn't.
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 6, 2020

@danwinship: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[4.2] Fix reinitialization of deny-all NetworkPolicy state on restart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship changed the title [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart Bug 1790440: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart Feb 6, 2020
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 6, 2020

@danwinship: This pull request references Bugzilla bug 1790440, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 1790440 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1790440: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship changed the title Bug 1790440: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart Bug 1793952: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart Feb 6, 2020
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 6, 2020

@danwinship: This pull request references Bugzilla bug 1793952, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "---" instead
  • expected Bugzilla bug 1793952 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1793952: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship

This comment has been minimized.

Copy link
Contributor Author

danwinship commented Feb 6, 2020

/bugzilla refresh

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 6, 2020

@danwinship: This pull request references Bugzilla bug 1793952, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas

This comment has been minimized.

Copy link
Contributor

juanluisvaladas commented Feb 7, 2020

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 7, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 10, 2020

Both backports have been verified in their upstream bugs.

@openshift-merge-robot openshift-merge-robot merged commit e9fab36 into openshift:release-4.2 Feb 10, 2020
7 checks passed
7 checks passed
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-upgrade Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
ci/prow/verify Job succeeded.
Details
ci/prow/verify-deps Job succeeded.
Details
tide In merge pool.
Details
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 10, 2020

@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1793952 has been moved to the MODIFIED state.

In response to this:

Bug 1793952: [4.2] Fix reinitialization of deny-all NetworkPolicy state on restart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.