Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1803149: Rebase SDN to kubernetes 1.17.2 #108

Merged
merged 2 commits into from Feb 14, 2020

Conversation

juanluisvaladas
Copy link
Contributor

@juanluisvaladas juanluisvaladas commented Feb 11, 2020

  • Merged the contents of Bug 1801737: drop firewalld monitoring, add better iptables monitor #39 into master

  • Rebase SDN to Kubernetes 1.17.2

  • Replaced go 1.12 for 1.13 in images.

  • Removed unnecessary dependencies: During the migration to go modules
    a bunch of dependencies were defined explicitly so that we had an
    exact equivalent.

  • OsdnProxy: Added OnNodeXxx functions so that it's compatible with
    service topology.

  • HybridProxy: Added empty OnNodeXxx functions so that it implements
    the proxier interface. This proxy is not compatible with service
    topology.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2020
danwinship and others added 2 commits February 11, 2020 18:48
Replaced go 1.12 for 1.13 in images.

Removed unnecessary dependencies: During the migration to go modules
  a bunch of dependencies were defined explicitly so that we had an
  exact equivalent.

OsdnProxy: Added OnNodeXxx functions so that it's compatible with
  service topology.

HybridProxy: Added empty OnNodeXxx functions so that it implements
  the proxier interface. This proxy is not compatible with service
  topology.
@juanluisvaladas juanluisvaladas changed the title [WIP] Rebase SDN to kubernetes 1.17.2 Rebase SDN to kubernetes 1.17.2 Feb 11, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2020
@juanluisvaladas
Copy link
Contributor Author

Needs a review: The few things I didn't mention earlier:

We need openshift/release#7121 merged before make verify-deps can pass. This happens because go mod vendor produces different results in go 1.12 and go 1.13

This PR includes a commit which doesn't compile: 3b71b6b
Because according to the conversation today having every commit compilable is preferred but not mandatory I preferred preserving git blame over having everything compiling

I sneaked a exception for the directory .vscode in .gitignore

@juanluisvaladas
Copy link
Contributor Author

/test e2e-gcp
/test e2e-aws

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@juanluisvaladas
Copy link
Contributor Author

/retest

@juanluisvaladas
Copy link
Contributor Author

Verify-deps passed with go 1.13 which means after this is merged stuff will be mergeable again

@juanluisvaladas
Copy link
Contributor Author

/retitle Bug 1803149: Rebase SDN to kubernetes 1.17.2

@openshift-ci-robot openshift-ci-robot changed the title Rebase SDN to kubernetes 1.17.2 Bug 1803149: Rebase SDN to kubernetes 1.17.2 Feb 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1803149, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1803149: Rebase SDN to kubernetes 1.17.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1803149, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1803149, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3b217b8 into openshift:master Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: All pull requests linked via external trackers have merged. Bugzilla bug 1803149 has been moved to the MODIFIED state.

In response to this:

Bug 1803149: Rebase SDN to kubernetes 1.17.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants