New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1803149: Rebase SDN to kubernetes 1.17.2 #108
Bug 1803149: Rebase SDN to kubernetes 1.17.2 #108
Conversation
c37c704
to
0f44cb6
Compare
Replaced go 1.12 for 1.13 in images. Removed unnecessary dependencies: During the migration to go modules a bunch of dependencies were defined explicitly so that we had an exact equivalent. OsdnProxy: Added OnNodeXxx functions so that it's compatible with service topology. HybridProxy: Added empty OnNodeXxx functions so that it implements the proxier interface. This proxy is not compatible with service topology.
0f44cb6
to
fcaba0d
Compare
|
Needs a review: The few things I didn't mention earlier: We need openshift/release#7121 merged before make verify-deps can pass. This happens because This PR includes a commit which doesn't compile: 3b71b6b I sneaked a exception for the directory .vscode in .gitignore |
|
/test e2e-gcp |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, juanluisvaladas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Verify-deps passed with go 1.13 which means after this is merged stuff will be mergeable again |
|
/retitle Bug 1803149: Rebase SDN to kubernetes 1.17.2 |
|
@juanluisvaladas: This pull request references Bugzilla bug 1803149, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@juanluisvaladas: This pull request references Bugzilla bug 1803149, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@juanluisvaladas: This pull request references Bugzilla bug 1803149, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@juanluisvaladas: All pull requests linked via external trackers have merged. Bugzilla bug 1803149 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Merged the contents of Bug 1801737: drop firewalld monitoring, add better iptables monitor #39 into master
Rebase SDN to Kubernetes 1.17.2
Replaced go 1.12 for 1.13 in images.
Removed unnecessary dependencies: During the migration to go modules
a bunch of dependencies were defined explicitly so that we had an
exact equivalent.
OsdnProxy: Added OnNodeXxx functions so that it's compatible with
service topology.
HybridProxy: Added empty OnNodeXxx functions so that it implements
the proxier interface. This proxy is not compatible with service
topology.