Bug 1878731: vxlan_monitor_test: fix flake #186
Conversation
openshift-ci-robot
added
the
approved
| } | ||
|
|
||
| // GetUpdates returns the updates in a random order | ||
| if !(update[0].nodeIP == "192.168.1.1" && update[1].nodeIP == "192.168.1.3") && |
There was a problem hiding this comment.
should this be an OR? if the first is true the second is false, no?
There was a problem hiding this comment.
Not sure which && you're saying should be an ||, but the condition is correct. If the first parenthesized expression is true (update 0 is 192.168.1.1 and update 1 is 192.168.1.3) then we are ok and don't want to hit the t.Fatalf. And if the second parenthesized expression is true (update 0 is 192.168.1.3 and update 1 is 192.168.1.1) then we are ok and don't want to hit the t.Fatalf. Only if both parenthesized expressions are false do we want to fail the test. So if !(X) && !(Y) { t.Fatalf(...) }
There was a problem hiding this comment.
I got it now sorry, thanks for the clarification
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship, juanluisvaladas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danwinship
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@danwinship: This pull request references Bugzilla bug 1824203, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
danwinship
changed the title
openshift-ci-robot
removed
the
bugzilla/severity-urgent
|
@danwinship: This pull request references Bugzilla bug 1878731, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-high
|
@danwinship: This pull request references Bugzilla bug 1878731, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/cherrypick release-4.4 |
|
@danwinship: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.5 |
|
@danwinship: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danwinship: All pull requests linked via external trackers have merged: Bugzilla bug 1878731 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danwinship: new pull request created: #190 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danwinship: new pull request created: #191 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The test was trying to take advantage of the fact that the updates were guaranteed to happen in order, but forgot that they weren't guaranteed to be returned in order...
/assign @juanluisvaladas