Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1762580: Enable conntrack for ovs-multitenant unless userspace proxy #189

Merged
merged 2 commits into from Sep 18, 2020
Merged

Bug 1762580: Enable conntrack for ovs-multitenant unless userspace proxy #189

merged 2 commits into from Sep 18, 2020

Conversation

juanluisvaladas
Copy link
Contributor

Should I do the same for ovs-subnet as well? I think it makes sense but I doubt anyone actually cares about this in ovs-subnet.

/assign @danwinship

Juan-Luis de Sousa-Valadas Castaño and others added 2 commits September 14, 2020 11:45
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1762580, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1762580: Enable conntrack for ovs-multitenant unless userspace proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas juanluisvaladas mentioned this pull request Sep 14, 2020
Closed
@knobunc
Copy link
Contributor

knobunc commented Sep 15, 2020

/retest

@juanluisvaladas
Copy link
Contributor Author

@danwinship can you PTAL?

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit 44e678b into openshift:master Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1762580 has not been moved to the MODIFIED state.

In response to this:

Bug 1762580: Enable conntrack for ovs-multitenant unless userspace proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: All pull requests linked via external trackers have merged:

Bugzilla bug 1762580 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 24, 2020
Closed
@openshift-cherrypick-robot
Copy link

@juanluisvaladas: new pull request created: #224

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas juanluisvaladas mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juanluisvaladas @openshift-ci-robot @knobunc @danwinship @openshift-cherrypick-robot @openshift-merge-robot