update to kube 1.20 #227
update to kube 1.20 #227
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
danwinship
force-pushed
the
rebase-1.20
branch
from
21f1548
to
717661a
Compare
|
So the problem here (and probably in #219 too) is that it's not creating any iptables service rules... |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, knobunc, rcarrillocruz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| @@ -43,7 +45,16 @@ func readProxyConfig(filename string) (*kubeproxyconfig.KubeProxyConfiguration, | |||
| if err := o.Complete(); err != nil { | |||
| return nil, err | |||
| } | |||
| return o.GetConfig(), nil | |||
|
|
|||
| config := o.GetConfig() | |||
There was a problem hiding this comment.
Is there a reason we can't disable the endpointslice featuregates in the config file itself, so we don't need the changes you added to readProxyConfig?
Otherwise LGTM.
There was a problem hiding this comment.
"because CI is on fire and I didn't want to try to get a CNO PR in too". But I'll fix that later...
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Update to
s d n -4.7-kubernetes-1.20-rc.0. Obsoletes #219 (which it's partially based on)/cc @tssurya