New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1966521: proxy: don't re-check every userspace proxy rule on every change #342
Bug 1966521: proxy: don't re-check every userspace proxy rule on every change #342
Conversation
/hold |
@danwinship: This pull request references Bugzilla bug 1966521, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@danwinship: This pull request references Bugzilla bug 1966521, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f3ba77d
to
6294387
Compare
6294387
to
f1ea7f3
Compare
/bugzilla refresh |
@danwinship: This pull request references Bugzilla bug 1966521, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
does it work? |
f1ea7f3
to
1fe59d6
Compare
The userspace proxy re-checks every one of its rules every time anything changes, to ensure that rules accidentally deleted by iptables or firewalld restart get recreated promptly. But this sucks up a ton of CPU when there are lots of idled services and lots of changes to other (unrelated) services. Fix it to only do the full re-check in response to openshift-sdn's iptables.Monitor being triggered, rather than on every sync.
1fe59d6
to
70ee975
Compare
yes, it drastically cuts down on calls to |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@danwinship: All pull requests linked via external trackers have merged: Bugzilla bug 1966521 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The userspace proxy re-checks every one of its rules every time
anything changes, to ensure that rules accidentally deleted by
iptables or firewalld restart get recreated promptly. But this sucks
up a ton of CPU when there are lots of idled services and lots of
changes to other (unrelated) services.
Fix it to only do the full re-check in response to openshift-sdn's
iptables.Monitor being triggered, rather than on every sync.