Bug 1753216: Clean up egress IPs on startup #51
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@danwinship: This pull request references Bugzilla bug 1753216, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/M
danwinship
force-pushed
the
egressip-cleanup
branch
from
06b2226
to
88d43b6
Compare
|
clever |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1753216 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If a node lost an egress IP while the sdn process was being restarted, the sdn wouldn't remove the stale egress IP from the node's interface, so you'd end up with two nodes fighting over the packets.
This fixes that by (1) labeling the egress IPs we add so that we can recognize them later, and (2) running a cleanup after we've finished syncing with the master on startup.
(Also,
node.egressIPWatcherhad a mutex that it wasn't using... but it turns out that this isn't a problem because its methods are only called fromcommon.EgressIPTracker, which does use a mutex when calling the watcher methods. I probably meant to delete the mutex when I split out thecommonparts of the egress IP code, but forgot.)