Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1760103: Adjust SDN setup so AlreadySetUp check will fail on a half-set-up node #52

Merged

Conversation

danwinship
Copy link
Contributor

See details at https://bugzilla.redhat.com/show_bug.cgi?id=1760103#c12, but the basic idea is that if SDN gets killed partway through SDN setup, we want to make sure the next SDN pod retries setup from the top rather than mistakenly accepting the half-set-up network.

@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Bugzilla bug 1760103, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1760103: Adjust SDN setup so AlreadySetUp check will fail on a half-set-up node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2019
@danwinship
Copy link
Contributor Author

/cc @squeed

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 14, 2019
@dcbw
Copy link
Member

dcbw commented Oct 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit adab615 into openshift:master Oct 15, 2019
@openshift-ci-robot
Copy link
Contributor

@danwinship: All pull requests linked via external trackers have merged. Bugzilla bug 1760103 has been moved to the MODIFIED state.

In response to this:

Bug 1760103: Adjust SDN setup so AlreadySetUp check will fail on a half-set-up node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship danwinship deleted the sdn-setup-ordering branch October 21, 2019 12:38
@juanluisvaladas
Copy link
Contributor

/cherrypick release-4.2

@openshift-cherrypick-robot

@juanluisvaladas: new pull request created: #87

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants