New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 support and multiple CIDR support to SubnetAllocator #66
Add IPv6 support and multiple CIDR support to SubnetAllocator #66
Conversation
/cc @russellb |
0181b48
to
657ee53
Compare
/cc @markmc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @danwinship
657ee53
to
594bd97
Compare
A copy of the code is used by ovn-kubernetes too, so make it more shareable again.
594bd97
to
fec1c5f
Compare
updated to skip the 0 subnet on IPv6, because it's weird that pod IPs on the first node look like "fd01::P", but pod IPs on all other nodes look like "fd01:0:0:S::P" |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, markmc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
Pulls in changes to support multiple subnets and to support IPv6: openshift/sdn#66
Pulls in changes to support multiple subnets and to support IPv6: openshift/sdn#66
Pulls in changes to support multiple subnets and to support IPv6: openshift/sdn#66
Pulls in changes to support multiple subnets and to support IPv6: openshift/sdn#66
This extends SubnetAllocator to support IPv6 ClusterNetworkCIDRs, and then also moves the code from OsdnMaster for handling multiple subnets and makes it part of SubnetAllocator instead.
(Of course, with stock OCP you can't configure an IPv6 ClusterNetwork so this should have no effect on end users at this point, and thus doesn't count as a feature, and would be exempt on IPv6 grounds even if it did.)
ovn-kubernetes currently vendors an older copy of SubnetAllocator (via
"github.com/openshift/origin/pkg/util/netutils"
) and then independently reimplements the multiple CIDR stuff on top of that. My intention was that it could be updated to either copy+paste or vendor this version instead, to provide IPv6 support there as well (and to remove the duplicated multiple CIDR code).