Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart #96

Merged

Conversation

juanluisvaladas
Copy link
Contributor

If a project has only a deny-all rule and pods running on it,
npNameSpace.inUse was set to false, this commit sets it to true.

If inUse is set to false, the node will not update the
npNamespace if new rules are created until new pods are created.

More details on BZ#1790440

@juanluisvaladas
Copy link
Contributor Author

/retitle Bugzilla 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart

@openshift-ci-robot openshift-ci-robot changed the title Fix reinitialization of deny-all NetworkPolicy state on restart Bugzilla 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@juanluisvaladas
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas
Copy link
Contributor Author

/retitle Bug 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart

@openshift-ci-robot openshift-ci-robot changed the title Bugzilla 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart Bug 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart Jan 20, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: This pull request references Bugzilla bug 1790440, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 20, 2020
@juanluisvaladas
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2020
@juanluisvaladas juanluisvaladas force-pushed the fix-netpol-init branch 2 times, most recently from 79a8743 to acc2d80 Compare January 21, 2020 09:59
@juanluisvaladas
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020
@juanluisvaladas juanluisvaladas force-pushed the fix-netpol-init branch 2 times, most recently from 1661e9d to a97ba8b Compare January 21, 2020 10:10
@juanluisvaladas
Copy link
Contributor Author

/retest

pkg/network/node/ovscontroller.go Outdated Show resolved Hide resolved
pkg/network/node/ovscontroller_test.go Outdated Show resolved Hide resolved
If a project has only a deny-all rule and pods running on it,
npNameSpace.inUse was set to false, this commit sets it to true.

If inUse is set to false, the node will not update the
npNamespace if new rules are created until new pods are created.

More details on BZ#1790440
@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, juanluisvaladas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@rcarrillocruz
Copy link
Contributor

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6e137ec into openshift:master Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

@juanluisvaladas: All pull requests linked via external trackers have merged. Bugzilla bug 1790440 has been moved to the MODIFIED state.

In response to this:

Bug 1790440: Fix reinitialization of deny-all NetworkPolicy state on restart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanluisvaladas juanluisvaladas deleted the fix-netpol-init branch January 22, 2020 09:11
@juanluisvaladas
Copy link
Contributor Author

/cherry-pick release-4.3

@openshift-cherrypick-robot

@juanluisvaladas: new pull request created: #98

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palonsoro
Copy link
Contributor

/cherry-pick release-4.2

@openshift-cherrypick-robot

@palonsoro: new pull request created: #99

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants