Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1890939: Handle pods from other kinds properly #25

Merged
merged 7 commits into from Oct 29, 2020
Merged

Bug 1890939: Handle pods from other kinds properly #25

merged 7 commits into from Oct 29, 2020

Conversation

zshi-redhat
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bz1890939

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@zshi-redhat zshi-redhat changed the title Bz1890939 Bug1890939: Handle pods from other kinds properly Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug1890939: Handle pods from other kinds properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat zshi-redhat changed the title Bug1890939: Handle pods from other kinds properly Bug 1890939: Handle pods from other kinds properly Oct 23, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Bugzilla bug 1890939, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1846333 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1846333 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

Bug 1890939: Handle pods from other kinds properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zshi-redhat and others added 6 commits October 26, 2020 09:34
@zshi-redhat
import via new multus pkg: gopkg.in/intel/multus-cni.v3/types
883b738
@zshi-redhat
switch to go mod
b7d1d92
@zshi-redhat
update vendor pkgs
cf49144
@zshi-redhat
Update client go and accommodate the API change (openshift#25)
4b6ba93 
* update k8s.io/client-go version

* accormmodate client-go API changes

* Use alpine golang-1.13 for building image

Build image with golang-1.12 hit below error after upgrading vendor pkgs:
vendor/k8s.io/apimachinery/pkg/util/errors/errors.go:99:10: undefined: errors.Is
@pperiyasamy @zshi-redhat
Handle pods from other kinds properly (openshift#28)
e70becb 
* Handle pods properly from deployment, daemonset or statefulset

This commit makes sure appropriate namespace is retrieved from
pod's replicaset/daemonset/replicaset incase if its deployed
using other kinds.
It would enable network-resources-injector to look for network-
attachment-definition object from the correct namespace.

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

* Add check for replicationcontroller pod

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>

* Use switch case instead of if-else logic

Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
@zshi-redhat
add default handler for getting ownerReference
c25dbe2
@zshi-redhat
Copy link
Contributor Author

/retest

@zshi-redhat
Copy link
Contributor Author

/retest

2 similar comments
@zshi-redhat
Copy link
Contributor Author

/retest

@zshi-redhat
Copy link
Contributor Author

/retest

@zshi-redhat
Copy link
Contributor Author

/cc @pliurh

@dougbtv
Copy link
Member

dougbtv commented Oct 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@knobunc
Copy link

knobunc commented Oct 27, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, knobunc, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dougbtv,zshi-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dougbtv
Copy link
Member

dougbtv commented Oct 27, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dougbtv: An error was encountered adding this pull request to the external tracker bugs for bug 1890939 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 1004: The combination of ext_type_* fields matched more than one External Tracker.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 28, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 28, 2020
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1890939, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1846333 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1846333 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Oct 28, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 28, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 28, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e0fce83 into openshift:release-4.5 Oct 29, 2020
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1890939 has been moved to the MODIFIED state.

In response to this:

Bug 1890939: Handle pods from other kinds properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba pushed a commit to SchSeba/sriov-dp-admission-controller that referenced this pull request Jul 28, 2022
@zshi-redhat
Update client go and accommodate the API change (openshift#25)
51ce8bc 
* update k8s.io/client-go version

* accormmodate client-go API changes

* Use alpine golang-1.13 for building image

Build image with golang-1.12 hit below error after upgrading vendor pkgs:
vendor/k8s.io/apimachinery/pkg/util/errors/errors.go:99:10: undefined: errors.Is
SchSeba pushed a commit to SchSeba/sriov-dp-admission-controller that referenced this pull request Jun 27, 2023
@zshi-redhat
Update client go and accommodate the API change (openshift#25)
c045a3e 
* update k8s.io/client-go version

* accormmodate client-go API changes

* Use alpine golang-1.13 for building image

Build image with golang-1.12 hit below error after upgrading vendor pkgs:
vendor/k8s.io/apimachinery/pkg/util/errors/errors.go:99:10: undefined: errors.Is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 Awaiting requested review from s1061123

@squeed squeed Awaiting requested review from squeed

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@dougbtv dougbtv

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@zshi-redhat @openshift-ci-robot @dougbtv @knobunc @sdodson @openshift-bot @openshift-merge-robot @pperiyasamy