BUG 1798043: Optimize VF configure logic #146
Conversation
openshift-ci-robot
added
the
size/M
pliurh
force-pushed
the
vf-config
branch
2 times, most recently
from
ef77813
to
0462b81
Compare
| glog.Errorf("configSriovDevice(): fail to set NumVfs for device %s", iface.PciAddress) | ||
| return err | ||
| // set numVFs | ||
| if iface.NumVfs != ifaceStatus.NumVfs { |
There was a problem hiding this comment.
This is checked in needUpdate, is there other reason to check it here again?
There was a problem hiding this comment.
needUpdate will return 'True' if any of the parameter has been updated. However, we need to check if one parameter shall be updated separately before executing.
| if err != nil { | ||
| glog.Warningf("configSriovDevice(): fail to set mtu for PF %s: %v", iface.PciAddress, err) | ||
| return err | ||
| if iface.Mtu > 0 && iface.Mtu != ifaceStatus.Mtu { |
Check whether desired state is the same as the current one before executing.
pliurh
changed the title
|
@pliurh: This pull request references Bugzilla bug 1798043, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@pliurh: This pull request references Bugzilla bug 1798043, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
@pliurh: All pull requests linked via external trackers have merged. Bugzilla bug 1798043 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update Webhook Configuration objects when Reconciling
Check whether desired state is the same as the current one before
executing.