Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize multi-nodes draining logic #165

Merged
merged 1 commit into from Apr 10, 2020

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Mar 18, 2020

  1. Check if any other node is draining by the operator before starting draining.
    Make draining running in serial when more than one node needs to be drained.
  2. Change the timeout of draining to '-1' following the MCO.
  3. Remove the timeout for Kube client.

@pliurh
Copy link
Contributor Author

pliurh commented Mar 18, 2020

/test e2e-aws

5 similar comments
@pliurh
Copy link
Contributor Author

pliurh commented Mar 19, 2020

/test e2e-aws

@pliurh
Copy link
Contributor Author

pliurh commented Mar 19, 2020

/test e2e-aws

@pliurh
Copy link
Contributor Author

pliurh commented Mar 19, 2020

/test e2e-aws

@pliurh
Copy link
Contributor Author

pliurh commented Mar 20, 2020

/test e2e-aws

@pliurh
Copy link
Contributor Author

pliurh commented Mar 23, 2020

/test e2e-aws

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020
Check if other node is draining by the operator before starting draining.
Make draining running in serial when more than one node needs to be drained.
@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit ddef424 into openshift:master Apr 10, 2020
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Aug 17, 2021
NRI: use control switch configmap to enable hugepage injection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants