Bug 1834141: Fix draining watch #207
Conversation
|
PTAL |
|
@SchSeba does this always happen? |
|
@SchSeba Could you create a BZ for this issue, and describe how to reproduce it? |
This commit fix the draining watch. Before this commit we stop the informer and use is lister to update the node. That didn't update the node in the cluster only the object itself so the node object inside the cluster stuck on Draining for ever. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
fix_draning_annotation
branch
from
e04ebb6
to
623695f
Compare
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@SchSeba: This pull request references Bugzilla bug 1834141, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
|
@SchSeba: All pull requests linked via external trackers have merged: openshift/sriov-network-operator#207. Bugzilla bug 1834141 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reload VF driver only when rdma is enabled
SriovNetworkNodeState is outdated. IsRdma field was introduced in the PR openshift#207. This patch syncs CRDs between config/crd/bases and helm chart.
SriovNetworkNodeState is outdated. IsRdma field was introduced in the PR openshift#207. This patch syncs CRDs between config/crd/bases and helm chart.
This commit fix the draining watch.
Before this commit we stop the informer and use is lister to update the node.
That didn't update the node in the cluster only the object itself so the node object
inside the cluster stuck on Draining for ever.
Signed-off-by: Sebastian Sch sebassch@gmail.com