Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1834371: Change the tests image #209

Merged
merged 1 commit into from May 12, 2020
Merged

Bug 1834371: Change the tests image #209

merged 1 commit into from May 12, 2020

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented May 11, 2020

This Commit is base on the CNF repo change openshift-kni/cnf-features-deploy#196

Signed-off-by: Sebastian Sch sebassch@gmail.com

fedepaol
fedepaol reviewed May 11, 2020
View reviewed changes
test/util/images/images.go Outdated
// For returns the image to be used for the given key
func For(name string) string {
img, ok := images[name]
// TestImage returns the test image to be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be just Test as the package name is already images.

Also, since there's only one image the map is redundant.
You can use directly the registry - cnfTestsImage variable

@SchSeba SchSeba force-pushed the change_test_image branch 2 times, most recently from 3076a8f to 3ae23e6 Compare May 11, 2020 12:24
@fedepaol
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2020
@fedepaol
Copy link
Member

/hold
Waiting for validation

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2020
@fedepaol
Copy link
Member

/test e2e-aws

2 similar comments
@fedepaol
Copy link
Member

/test e2e-aws

@SchSeba
Copy link
Contributor Author

SchSeba commented May 11, 2020

/test e2e-aws

@SchSeba SchSeba changed the title Change the tests image Bug 1834371: Change the tests image May 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 11, 2020
@openshift-ci-robot
Copy link
Contributor

@SchSeba: This pull request references Bugzilla bug 1834371, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1834371: Change the tests image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 11, 2020
Merged
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2020
@fedepaol
Copy link
Member

/test e2e-aws

1 similar comment
@fedepaol
Copy link
Member

/test e2e-aws

@SchSeba SchSeba force-pushed the change_test_image branch 3 times, most recently from eecd74a to dc7f344 Compare May 12, 2020 20:04
@SchSeba
Change the tests image
633f6ca 
This commit is base on the CNF repo change openshift-kni/cnf-features-deploy#196

This commit also remove the check for logs as it's not needed anymore the bug was fixed by
openshift#175

Also here we fix some test issues related to the policyName field

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@fedepaol
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@fedepaol
Copy link
Member

/test e2e-aws

1 similar comment
@fedepaol
Copy link
Member

/test e2e-aws

@fedepaol
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8079cf0 into openshift:master May 12, 2020
@openshift-ci-robot
Copy link
Contributor

@SchSeba: All pull requests linked via external trackers have merged: openshift/sriov-network-operator#205, openshift/sriov-network-operator#209. Bugzilla bug 1834371 has been moved to the MODIFIED state.

In response to this:

Bug 1834371: Change the tests image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Dec 27, 2021
@pliurh
Merge pull request openshift#209 from AbdYsn/add-hello-work-flow
923cb4d 
Add pr-ci-triggers workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol fedepaol left review comments

Assignees

@fedepaol fedepaol

Labels
bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SchSeba @fedepaol @openshift-ci-robot @openshift-merge-robot