Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-4.6] Bug 1960263: Pause MCP before draining/rebooting node #506

Merged
merged 2 commits into from Jun 3, 2021
Merged

[Release-4.6] Bug 1960263: Pause MCP before draining/rebooting node #506

merged 2 commits into from Jun 3, 2021

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented May 13, 2021

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@pliurh: This pull request references Bugzilla bug 1960263, which is invalid:

  • expected dependent Bugzilla bug 1960103 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1921321 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[Release-4.6] Bug 1960263: Pause MCP before draining/rebooting node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 13, 2021
@openshift-ci openshift-ci bot requested a review from s1061123 May 13, 2021 13:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@pliurh
Copy link
Contributor Author

pliurh commented May 13, 2021

/retest

@pliurh
Pause MCP before draining/rebooting node
9fe07d2 
The config daemon instance on each node need to compete for the 'Draining' lock before
it can draining/rebooting a node.

After a config daemon instance gets the lock, it checks its MachineConfigPool conditions.
If the MCP is in ready state, it will pause the MCP then process, otherwise, it wait for
the MCP getting ready. The MCP will be resumed after the config daemon and release the
lock after the config dameon finishes its work.
@pliurh
Add machineconfiguration cluster rule to CSV manifest
c15dc47
@pliurh pliurh requested a review from fedepaol May 21, 2021 12:45
@pliurh
Copy link
Contributor Author

pliurh commented May 21, 2021

@fedepaol @SchSeba PTAL

@fedepaol
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

@fedepaol: This pull request references Bugzilla bug 1960263, which is invalid:

  • expected dependent Bugzilla bug 1960103 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member

LGTM

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2021

@openshift-bot: This pull request references Bugzilla bug 1960263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1960103 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1960103 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi May 28, 2021 01:00
@derekwaynecarr
Copy link
Member

[patch-manager] 🚀 Approved for z-stream by score: 1.50

approved

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit a54201d into openshift:release-4.6 Jun 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

@pliurh: All pull requests linked via external trackers have merged:

Bugzilla bug 1960263 has been moved to the MODIFIED state.

In response to this:

[Release-4.6] Bug 1960263: Pause MCP before draining/rebooting node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jun 23, 2021
Merged
liornoy pushed a commit to liornoy/sriov-network-operator-openshift that referenced this pull request Sep 19, 2023
@zeeke
Merge pull request openshift#506 from liornoy/use-namespace-const
2097c2a 
Use the OPERATOR_NAMESPACE var in the k8sreporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba Awaiting requested review from SchSeba

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@s1061123 s1061123 Awaiting requested review from s1061123

@fedepaol fedepaol Awaiting requested review from fedepaol

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@zshi-redhat zshi-redhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pliurh @fedepaol @zshi-redhat @openshift-bot @derekwaynecarr @openshift-merge-robot