Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1732945: Capture cluster infrastructure metrics #211

Merged
merged 1 commit into from Aug 6, 2019
Merged

Bug 1732945: Capture cluster infrastructure metrics #211

merged 1 commit into from Aug 6, 2019

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Aug 5, 2019

Cherrypick of #205 into 4.1.z.

@smarterclayton @squat

@openshift-ci-robot
Copy link
Contributor

@brancz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

metrics: Capture cluster infrastructure metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2019
@brancz brancz changed the title metrics: Capture cluster infrastructure metrics Bug 1731232,1731228: Capture cluster infrastructure metrics Aug 5, 2019
@openshift-ci-robot
Copy link
Contributor

@brancz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1731232,1731228: Capture cluster infrastructure metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brancz
Copy link
Contributor Author

brancz commented Aug 5, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@brancz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

squat
squat approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

we'll need to bump telemeter client in cluster-monitoring-operator to include these metrics in its whitelist as well

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@brancz brancz changed the title Bug 1731232,1731228: Capture cluster infrastructure metrics Bug 1731228: Capture cluster infrastructure metrics Aug 5, 2019
@openshift-ci-robot
Copy link
Contributor

@brancz: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1731228: Capture cluster infrastructure metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 5, 2019
@brancz brancz changed the title Bug 1731228: Capture cluster infrastructure metrics Bug 1732945: Capture cluster infrastructure metrics Aug 5, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 5, 2019
@openshift-ci-robot
Copy link
Contributor

@brancz: This pull request references a valid Bugzilla bug. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732945: Capture cluster infrastructure metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarterclayton @crawford
metrics: Capture cluster infrastructure metrics
129911a 
Knowing the infrastructure provider and feature set are key for
triaging upgrade failures in production use cases.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2019
@smarterclayton
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, smarterclayton, squat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,smarterclayton,squat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link
Contributor

crawford commented Aug 5, 2019

/retest

@crawford crawford added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit ea047d9 into openshift:release-4.1 Aug 6, 2019
@brancz brancz deleted the cherry-pick-205 branch August 6, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

@squat squat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brancz @openshift-ci-robot @smarterclayton @crawford @squat @openshift-merge-robot