New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1827530: Bump to v0.12.2 #26
Bug 1827530: Bump to v0.12.2 #26
Conversation
…os-io#2443) * store: proxy: add test for deadlocking problem Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> * store: proxy: add fix for timeouts Checking here if the series context has ended is the correct fix here. We want to check it because if any of the other Series() calls error out then the context is canceled. So, it is equal to checking for errors "downstream", in `mergedSeriesSet`. Also, `handleErr()` here is the correct function to use because in such a case we want to set `s.err` -- if `io.EOF` still hasn't been received then it means that StoreAPI still has some data that it wants to send but hasn't yet. With this, the previously added test passes. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> Co-authored-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Related to: thanos-io#2459 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Fixes: thanos-io#2471 This commit fixes an issue where multiple goroutines in the block fetcher filtering were concurrently accessing the same map. The goroutines were concurrently writing AND reading to the shared metas map. This commit guards this concurrent access by giving the DeduplicateFilter struct a mutex. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Fixes thanos-io#2459 (quick fix). This keeps the logic from the 0.11.0 which was good enough. Some improvement for future: thanos-io#2470 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: yeya24 <yb532204897@gmail.com> Signed-off-by: Lucas Servén Marín <lserven@gmail.com> Co-authored-by: yeya24 <yb532204897@gmail.com>
* Clear duplicateIDs at the beginning of Filter. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * CHANGELOG.md Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Address review feedback. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix whitespace noise. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * 🐳 🛴 Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
) * cmd: rule: do not wrap reload endpoint with '/' Do not wrap the router with `/` on the `/-/reload` endpoint. Otherwise, it is inaccessible when no prefix has been specified by the user. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> * CHANGELOG: update Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com> * e2e: rule: add test for reloading rules via /-/reload Add a test-case to the e2e tests for testing whether reloading rules via /-/reload works. Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
v0.12.2 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier: This pull request references Bugzilla bug 1827530, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @openshift/openshift-team-monitoring |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@simonpasquier: All pull requests linked via external trackers have merged: openshift/thanos#26, thanos-io/thanos#2533. Bugzilla bug 1827530 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.