New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #17
Add unit tests #17
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
afe45c1
to
81fed58
Compare
/retest |
f501916
to
aaf515d
Compare
pkg/check/testdata/default/README
Outdated
@@ -0,0 +1,13 @@ | |||
Generated using vcsim and vcgo, both v0.23.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: I think you mean govc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also reads bit weird - it looks like as if this readme was generated.
lets merge this. we can fix readme in a follow up. /lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
17 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/lgtm cancel |
To get the latest simulator
rebased |
6de5bc6
to
aaa28f3
Compare
The framework uses vCenter simulator. It simulates objects previously saved from "vcsim", i.e. some default vSpehere with 1 host + 2 VMs, and now present in the repository as pkg/check/testdata/default/*.xml.
And fix a bug in the datastore checks.
aaa28f3
to
88157e7
Compare
/lgtm |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
govc
to the latest released version.pkg/check/testdata/default
- that's how a simulated vCenter will look like. Added README there to be able to re-generate it when needed, with special attention to simulated datastore (it needs a real directory on filesystem).folder_test.go
does not have any error cases, we would need to simulate permission errors.tasks.go
, did not find a way how to inject a task to the simulator.@openshift/storage