New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2028966: Whereabouts should reconcile IP addresses [backport 4.8] #78
Bug 2028966: Whereabouts should reconcile IP addresses [backport 4.8] #78
Conversation
This will allow excluding the pod that is created in the default namespace i.e. kubectl wait --for=condition=Ready pod --timeout=30s -l app!=whereabouts Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
added sleep-for-race option for IPAM
Fix test to include error when IP pool total doesn't equal assigned WB pod IPs
As per [0] kind `load docker-image` commands are docker specific. This commit changes that instruction, using the generic `load image-archive` instead, which works both for podman and docker. [0] - kubernetes-sigs/kind#2027 Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
build: enable e2e testing for podman
containerd sends CNI CMD check instructions to the plugins, and whereabouts does not implement that command, returning with an error. As per the CNI specification - [0] - the runtime "may assume that a failed CHECK means the container is permanently in a misconfigured state." and as a results replies with a CNI del. By instructing the CRI to not send CNI checks we work around this issue. [0] - https://github.com/containernetworking/cni/blob/master/SPEC.md#check-check-containers-networking-is-as-expected Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Before checking for stale IP addresses, trigger the `ip-reconciler` tool, which will cleanup stale IP addresses. In order to manually run the reconciler, we need to build it first; as such, the github action must be updated. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
The ip-reconciler tool currently feature the logging level hard-coded to `debug`, which is too verbose. This commit makes it configurable, defaulting it to error level. The effective logging level is set to `verbose` in the daemonset spec. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
build, ip reconciler: have configurable logging
Use k8snetworkplumbingwg repo instead of dougbtv in sources
Define the reconciler as a system critical resource. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Fix reconciler spec
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
With this change the reconciler can run in two different ways: - when ran in a k8s pod, it does not require to be told how to connect to the cluster. - when ran as a binary, it does require to know how to connect to the cluster, via the -kubeconfig config option. The reconciler cron spec is updated to use the correct service account name, and also is updated to run in the `kube-system` namespace. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
All (non error) logs have the same verbosity; it would be interesting to see the reconciled IPs by default, as such I'm bumping this particular logging call to `verbose`. That enables users to `kubectl logs <reconciler-pod-name` and see which IP addresses got reconciled. The below calls would be bumped to `verbose`. ``` 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.100] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.111] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.113] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.118] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.13] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.170] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.18] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.3] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.35] 2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.4] 2021-10-20T15:50:01Z [debug] removed stale overlappingIP allocation [10.10.0.83] ``` Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
ip-reconciler: remove kubeconfig from k8s client
e2e tests: fix currently broken setup on kind clusters
Configurable sleep_for_race parameter
Add label app=whereabouts to ip-reconciler pod template
ip-reconciler: Add all non default interfaces to Pod IP list
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
ip-reconciler: do not reconcile pods in Pending phase
* reconciler, spec: forbid concurrent executions Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com> * reconciler, spec: remove complete pods We leave the default `failedJobsHistoryLimit` - 1 - to enable the user to debug the reconciler in case it fails. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com> * reconciler, spec: do not retry on error Since a new pod will be scheduled in 5 minutes, it is safer to just wait for the new reconcile cycle than insist on reconciling right now. This is important to prevent the cluster to clog further on constrained clusters. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label backport-risk-assessed |
/bugzilla refresh |
@dougbtv: This pull request references Bugzilla bug 2028966, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dougbtv: This pull request references Bugzilla bug 2028966, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
@dougbtv: All pull requests linked via external trackers have merged: Bugzilla bug 2028966 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This catches up to release v0.5.1 to integrate all IP reconciliation fixes.