Fix compatibility with pytest 3.8.0 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in pytest-dev/pytest#3973, pytest 3.8.0 introduced some code that ends up checking the `cwd` by accident. One of the tests in your test suites changes the `cwd` to a temporary directory, and this blows up some tests after it. This change uses the `monkeypatch` fixture to safe cwd-switching, by restoring it to the original value at the end of the test.
RonnyPfannschmidt
suggested changes
Sep 13, 2018
|
Fair enough, thanks! Done |
|
@nicoddemus @RonnyPfannschmidt Thanks! 😍 |
|
we are eager and happy to help people gravitate towards better testing, its been a pleasure 👍 |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 99.25% 99.25% +<.01%
==========================================
Files 26 26
Lines 3601 3602 +1
Branches 261 261
==========================================
+ Hits 3574 3575 +1
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in pytest-dev/pytest#3973, pytest 3.8.0
introduced some code that ends up checking the
cwdby accident. One ofthe tests in your test suites changes the
cwdto a temporary directory, andthis blows up some tests after it.
This change uses the
monkeypatchfixture to safe cwd-switching, byrestoring it to the original value at the end of the test.