Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Provide API for testing OpenSlide version #156

Open
bgilbert opened this Issue Mar 20, 2015 · 2 comments

Comments

Projects
None yet
2 participants
Owner

bgilbert commented Mar 20, 2015

Consider exposing the OpenSlide version in a machine-readable form (perhaps with a comparison function or macro) so applications can apply version-specific workarounds without parsing the output of openslide_get_version(). Also consider how bindings will expose this information.

bgilbert self-assigned this Mar 20, 2015

@bgilbert bgilbert modified the milestone: v3.4.1 Mar 20, 2015

Owner

bgilbert commented Mar 20, 2015

See #155 for an example use case.

@bgilbert bgilbert modified the milestone: v3.5.0, v3.4.1 Mar 22, 2015

Contributor

malaterre commented Apr 13, 2015

Since issue is still open, I'd like to extend the test to compile-time detection. Eg:

// only in 3.4.0 and up
#if OPENSLIDE_VERSION_MINOR > 3
  const char * vendor = openslide_detect_vendor( filename );
  return vendor == NULL;
#else
  return openslide_can_open( filename );
#endif

So OPENSLIDE_VERSION_MAJOR and OPENSLIDE_VERSION_MINOR would be exposed

bgilbert removed their assignment Aug 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment