Skip to content

Consider dropping GSlice allocator #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bgilbert opened this issue Mar 15, 2023 · 0 comments · Fixed by #435
Closed

Consider dropping GSlice allocator #430

bgilbert opened this issue Mar 15, 2023 · 0 comments · Fixed by #435
Labels
enhancement

Comments

@bgilbert
Copy link
Member

Slide format

All

Issue details

glib 2.76 converts the slice allocator implementation to a g_malloc wrapper, which has been under discussion since 2015. Consider switching to g_malloc everywhere to simplify our internals, e.g. eliminating _openslide_slice.

g_malloc is also a malloc wrapper since glib 2.46, but it provides some useful API affordances (e.g. automatic abort on allocation failure) so I'd be inclined to keep using it.
bgilbert added a commit to bgilbert/openslide that referenced this issue Apr 19, 2023
@bgilbert
Drop glib slice allocator
0d4d739 
glib deprecated it.

Fixes openslide#430.

Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
@bgilbert bgilbert mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop glib slice allocator bgilbert/openslide
1 participant
@bgilbert