[PHP8.2] Using ${var} in strings is deprecated fix#2078
Merged
Conversation
masaton0216
reviewed
Nov 28, 2024
Contributor
masaton0216
left a comment
There was a problem hiding this comment.
ご対応ありがとうございます。
挙げてくれた5ファイルは確認しました。
別途、下記1ファイルもHITしたのですが、これも対応しておいた方が良さげですかね?
Contributor
Author
こちら.envのMAIL_FROM_NAME置換処理で、このままで良いかとー。 参考:Laravel 11でも.envのMAIL_FROM_NAMEはこのままでした。 |
Contributor
|
了解です。マージしますー! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
上記修正です。
単体テスト
https://github.com/opensource-workshop/connect-cms/actions/runs/12021772987/job/33512856001
php8.2で画面表示にエラーがない事を確認しました。
(※ Connect1.x系のため、実際にはphp8.2はメール処理が動かないです。)
レビュー完了希望日
急ぎません
関連Pull requests/Issues
概要に記載
参考
なし
DB変更の有無
無し
チェックリスト