Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
移行のインポート時に、既に移行済みか確認するテーブル MigrationMapping を1件1件参照していますが、DBインデックスがありませんでした。
DBインデックスを追加したところ、参照速度が改善されましたので、プルリクエストを作成しました。
参考:MigrationMapping を1件1件参照
SQL参照速度
移行データ1件につき、1Selectしているため、
例えば10万件などの大量データの移行時、速度改善が期待できます。
レビュー完了希望日
なし
関連Pull requests/Issues
なし
参考
なし
DB変更の有無
有り
チェックリスト