Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Get rid of required "Site address" settings #698
This setting is a cause of much confusion. It would make deployment a lot easier if this settings was not required.
Webclients should find another way to determine the server's API address (for example detect the "/apps/" part of the URL).
This setting is also used for the base address for links that are put into emails, so for this reason alone the setting should stay.
Also used in:
So in short, the setting itself should not go, but for all those people getting the "BIMvie.ws is loading" message (forever), we could make it better by creating an embedded build so that it always works. However this would fix the js dependencies of BIMvie.ws, but the next thing it will fail on are the API calls (where to send them to?) Maybe this could all be fixed by giving better error messages, for example: