New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link includes in query language #705

Open
rubendel opened this Issue Feb 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@rubendel
Member

rubendel commented Feb 6, 2018

It would be useful to have the ability to link includes from within includes (but not on the fields).

For example the following could be simplified:

Now:

       "IfcOpenShell": {
         "type": "IfcOpenShell",
         "field": "CfsFaces",
         "include": {
            "type": "IfcFace",
            "field": "Bounds",
            "include": {
               "type": "IfcFaceBound",
               "field": "Bound",
               "include": {
                  "type": "IfcPolyLoop",
                  "field": "Polygon"
               }
            }
         }
      },
      "IfcClosedShell": {
         "type": "IfcClosedShell",
         "field": "CfsFaces",
         "include": {
            "type": "IfcFace",
            "field": "Bounds",
            "include": {
               "type": "IfcFaceBound",
               "field": "Bound",
               "include": {
                  "type": "IfcPolyLoop",
                  "field": "Polygon"
               }
            }
         }
      }

After:

       "IfcConnectedFaceSet": {
         "type": "IfcConnectedFaceSet",
         "field": "CfsFaces",
         "include": {
            "type": "IfcFace",
            "field": "Bounds",
            "include": {
               "type": "IfcFaceBound",
               "field": "Bound",
               "include": {
                  "type": "IfcPolyLoop",
                  "field": "Polygon"
               }
            }
         }
       },
       "IfcOpenShell": {
         "type": "IfcOpenShell",
         "superinclude": "IfcConnectedFaceSet"
      },
      "IfcClosedShell": {
         "type": "IfcClosedShell",
         "superinclude": "IfcConnectedFaceSet"
      }

Obviously in this example the types could have been combined in "IfcConnectedFaceSet" anyways, but there are also examples where you'd want to simplify the queries but only link to 1 of x subtypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment