New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove restriction project names need to be unique #915

Open
berlotti opened this Issue Jan 30, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@berlotti
Copy link
Member

berlotti commented Jan 30, 2019

Since there are unique ID's for projects, can the restriction that project names need to ben unique be removed?

@rubendel

This comment has been minimized.

Copy link
Member

rubendel commented Jan 30, 2019

Project names only need to be unique within their parent. Root projects only need to have a unique name among all the other root projects.

This restriction is not in place for a technical reason. It's not there because we did not have any other fields that are unique (poid for example). It is only there to avoid confusion for the users. Since the UUIDs are not meant to be displayed (hurts your eyes), I still don't think it is a good idea to drop this restriction.

@berlotti

This comment has been minimized.

Copy link
Member Author

berlotti commented Jan 30, 2019

Use case: project with name 'x' was started as ifc2x3tc1 project.
the project is deleted.
new project is started with name 'x' as ifc4 project.

At the moment this is not possible.
So maybe the rule of unique names in root projects is good, but without taking deleted projects into account?

@rubendel

This comment has been minimized.

Copy link
Member

rubendel commented Jan 30, 2019

For this specific use case I think a migration is in order (depends on #916).

But sure there are other use cases for this. There is another issue which I can't find in which a user suggested to also rename a project when it is deleted. We could for example change the name to "originalname-timestamp". When undeleting we could suggest to rename it back to the original (if the name still exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment