Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 117 does not produce geometry after installing version 125 in parallel #943

Open
epeter- opened this Issue Feb 21, 2019 · 22 comments

Comments

Projects
None yet
6 participants
@epeter-
Copy link

epeter- commented Feb 21, 2019

System: Windows 10 64 bit
Starting BIM Server from batch file and BIMserver Starter and launching a webbrowser

history: BIMserver was running as expected till yesterday, when i tried to install a version 125 in parallel.
all plugins were reinstalled manually as for the 117 version.

Describe the bug
I upload a IFC file 2x3 - a simple test file
Upload is correct, i can examine the tree, so everything looks fine
image

when i click on the "eye" icon to visualize the model sometimes for some models an error message is shown:

image

sometimes simply no 3d is not shown.

To Reproduce

Steps to reproduce the behavior:
checkin new ifc to project, try to visualize 3d

Expected behavior
show 3d

@JonasManuelKonstruktum

This comment has been minimized.

Copy link

JonasManuelKonstruktum commented Feb 26, 2019

We are having the same problem after only restarting 117.

@JonasManuelKonstruktum

This comment has been minimized.

Copy link

JonasManuelKonstruktum commented Feb 26, 2019

The issue seems to be that the server returns broken json like this:

{
		"_i": 17486907238,
		"_t": "GeometryInfo",
		"_s": 1,
		"_ebounds": {
			"_t": "Bounds",
			"min": {
				"_t": "Vector3f",
				"x": NaN,
				"y": NaN,
				"z": NaN
			},
			"max": {
				"_t": "Vector3f",
				"x": NaN,
				"y": NaN,
				"z": NaN
			}
		},
		"_eboundsUntransformed": {
			"_t": "Bounds",
			"min": {
				"_t": "Vector3f",
				"x": NaN,
				"y": NaN,
				"z": -1.51996493463552E14
			},
			"max": {
				"_t": "Vector3f",
				"x": NaN,
				"y": NaN,
				"z": 2.1733438968658447
			}
		},
		"primitiveCount": 788,
		"transformation": "AAAAAAAAAAAAAAAAAADwvwAAAAAAAAAAAAAAAAAAAAAAAAAAAADwPwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADwPwAAAAAAAAAAAAAAAAAAKEAAAAAAAAAkQJqZmZmZmQVAAAAAAAAA8D8=",
		"area": 0.0,
		"volume": 0.0,
		"hasTransparency": false,
		"ifcProductOid": 98109167,
		"density": NaN,
....

that contains a lot of NaN values.
Maybe this is not a geometry generation issue but encoding issue when sending to the client.
However I am completely lost as to what changed, because we only restarted our server for maintainance without changing the configuration.

@rubendel

This comment has been minimized.

Copy link
Member

rubendel commented Feb 26, 2019

Unfortunately there were a few versions of the IfcOpenShell plugin that - independently from the BIMserver plugin system - downloaded potential new versions of the binaries. We thought that would be useful for development purposes, but it turned out not to be. This has now changed, you as the user can now explicitly tell it to load a different version.

This only happened when restarting a BIMserver, which would explain why it happened at that point. The reason for the NaN is that the geometry would not be calculated correctly, and therefore also a lot of other properties were not.

BIMserver 1.5.125 and the IfcOpenShell plugin linked to it does not have this behaviour.

@klacol

This comment has been minimized.

Copy link

klacol commented Feb 26, 2019

We have encountered the same issue with BIMserver 1.5.117 as @epeter- and @JonasManuelKonstruktum. Thanks for reporting it so in detail.

It came suddenly, but we cannot asure, that the server was NOT restarted in between by somebody from our organization. So the restart could have been the explanation.

Is the only fix, an update to version 1.5.125, or is there another workaround?

@epeter-

This comment has been minimized.

Copy link
Author

epeter- commented Feb 26, 2019

Er found out that version 125 has problems reporting properties, but are still exploring / testing

@klacol

This comment has been minimized.

Copy link

klacol commented Feb 27, 2019

We found out, dass this issue is probably related to this issue:
opensourceBIM/IfcOpenShell-BIMserver-plugin#9

The conclusion in our internal ticket system is:

So we have to bite the bullet.
The models uploaded before the BIMserver restart can still be displayed. However, uploading new revisions will prevent the models from being displayed.
I had *** committed to '***.ARC' before restarting.
Display worked. Now after the restart the 2nd revision committed.
SyntaxError: Unexpected token N in JSON at position...

BIMserver update to 1.5.125 is then probably pending.
Update our project to current BIMserver API
change/test all method calls
change/test all string queries to the BIMserver
validifc has been renamed to ifc2x3tc1-stdlib
test concerns mapping and BIMexplorer
Create a new BIMserver setup

Is this the best way forward?

@JonasManuelKonstruktum

This comment has been minimized.

Copy link

JonasManuelKonstruktum commented Feb 27, 2019

would it be possible to re-release a version of the IfcOpenShell plugin that disables this behaviour and ist compatible to 117?

@hlg

This comment has been minimized.

Copy link
Member

hlg commented Feb 27, 2019

As a workaround I was successful to replace the binary manually. However you have to rename it to reflect the commit-sha of the release that BIMserver tries to download. This is quite dirty and opens the door to all sorts of confusion, since it obfuscates which IfcOpenShell version you are actually using.

@klacol

This comment has been minimized.

Copy link

klacol commented Feb 27, 2019

As a workaround I was successful to replace the binary manually. However you have to rename it to reflect the commit-sha of the release that BIMserver tries to download. This is quite dirty and opens the door to all sorts of confusion, since it obfuscates which IfcOpenShell version you are actually using.

And we would have to find a way to stop the automatic download of a new version on every restart.

@epeter-

This comment has been minimized.

Copy link
Author

epeter- commented Feb 27, 2019

and, in terms of versioning it might be a good idea to really create "versions" and not something between. it shall not be that a new release affects any installed predecessors!

@klacol

This comment has been minimized.

Copy link

klacol commented Feb 27, 2019

@epeter- Could you explain us the steps, that are needed to reset the plugins for an existing installation? Thanks!

@hlg

This comment has been minimized.

Copy link
Member

hlg commented Feb 27, 2019

And we would have to find a way to stop the automatic download of a new version on every restart.

If a file with the same name is already there it will not be overwritten (at least on Windows, did not test other OS). You may want to stop the server anyway for replacing the file and restart after.

and, in terms of versioning it might be a good idea to really create "versions" and not something between. it shall not be that a new release affects any installed predecessors!

I think it is well-understood what is wrong with these plugin versions. I just shared a quick-and-dirty workaround for those (like me) who insist on using outdated plugin versions such as 0.5.38 which works with BIMserver 1.5.117. This should work both for a new setup of the old BIMserver version as well as for existing installations.

@epeter-

This comment has been minimized.

Copy link
Author

epeter- commented Feb 27, 2019

@klacol - unfortunately not as @hlg solved that and i am still failing.
@

@klacol

This comment has been minimized.

Copy link

klacol commented Feb 27, 2019

Hey @epeter- , this worked for us:

  1. Stop BIMserver
  2. Goto folder "..\Database\tmp\org.opensourcebim.ifcopenshellplugin"
  3. Delete "IfcGeomServer-v0.6.0-33cbcc2-win64.exe"
  4. Rename "IfcGeomServer-v0.6.0-4380e1d-win64.exe" to "IfcGeomServer-v0.6.0-33cbcc2-win64.exe"
  5. Start BIMserver again

Then a commit and a visualization worked again.

@rubendel

This comment has been minimized.

Copy link
Member

rubendel commented Feb 28, 2019

@klacol and @hlg Yes that sounds like the perfect workaround.

We will not release a new version of the IOS plugin, simply to fix a (development) version of BIMserver.

@epeter- You are correct, as explained, this is now fixed in newer versions.

@cacu100

This comment has been minimized.

Copy link

cacu100 commented Mar 4, 2019

Hey @epeter- and klacol.
I have the same issue. I have a 1.5.117 war installation over tomcat in Centos OS. I can't find "..\Database\tmp\org.opensourcebim.ifcopenshellplugin" How can I fix it.
Thanks

@hlg

This comment has been minimized.

Copy link
Member

hlg commented Mar 4, 2019

@cacu100 it is just tmp\org.opensourcebim.ifcopenshellpluginin the home folder of your BIMserver install. In @klacol's case the home folder seems to be called Database, for you it is probably different.

@cacu100

This comment has been minimized.

Copy link

cacu100 commented Mar 4, 2019

Thanks @hlg very useful the information provided. I found the folder inside my webapps folder. Now I need know how can I get IfcGeomServer-v0.6.0-4380e1d executable file for linux to replace it inside this folder. In opensourceBIM/IfcOpenShell-BIMserver-plugin#9 @stegh provide the link to download the file for windows. But I'm using Centos

@hlg

This comment has been minimized.

Copy link
Member

hlg commented Mar 4, 2019

Replace win32 with linux32or linux64.

@cacu100

This comment has been minimized.

Copy link

cacu100 commented Mar 4, 2019

Thanks @hlg. Nice

@klacol

This comment has been minimized.

Copy link

klacol commented Mar 5, 2019

In @klacol's case the home folder seems to be called Database, for you it is probably different.

Ah, yes, we are running on Tomcat, and there the folder is configured in the server.xml and there in the param "homedir" of the host. So, this folder will be in different locations based on the environment.

@cacu100

This comment has been minimized.

Copy link

cacu100 commented Mar 5, 2019

Thanks @klacol for your reply. Yes, I found the correct path and file to replace on this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.